-
-
Notifications
You must be signed in to change notification settings - Fork 255
refactor: migrate assets controllers messenger #6745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sito/messenger/polling-controllers
…sito/messenger/assets-controllers
…sito/messenger/polling-controllers
…sito/messenger/assets-controllers
…sito/messenger/polling-controllers
…sito/messenger/assets-controllers
…sito/messenger/polling-controllers
…sito/messenger/assets-controllers
…ontroller' into mikesposito/messenger/polling-controllers * origin/mikesposito/messenger/approval-controller: Update changelogs following branch update Update messagingSystem references to messenger
…ntrollers' into mikesposito/messenger/assets-controllers * origin/mikesposito/messenger/polling-controllers: Update ESLint warning threshold Fix changelog mistakes from recent merges Update changelogs following branch update Update messagingSystem references to messenger
cryptodev-2s
previously approved these changes
Oct 26, 2025
Contributor
cryptodev-2s
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Base automatically changed from
mikesposito/messenger/polling-controllers
to
main
October 27, 2025 12:54
The base branch was changed.
cryptodev-2s
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR migrates all remaining assets controllers to
@metamask/messengerinstead of@metamask/base-controller. This is part of a larger effort to migrate all controllers to use@metamask/messenger.References
Checklist
Note
Migrates remaining assets controllers and tests from base-controller RestrictedMessenger to @metamask/messenger, updating metadata flags and event wiring.
@metamask/messenger):MultichainAssetsController,MultichainBalancesController,NftDetectionController,RatesController,TokenSearchDiscoveryDataControllernow useMessengertypes andthis.messengerforcall/subscribe/publish(replacingRestrictedMessenger/messagingSystem).delegate.@metamask/base-controller/nextandStateMetadata; replaceanonymouswithincludeInDebugSnapshotwhere applicable./next; adjust assertions to new metadata flags; minor test helpers tweaks.this.messenger.publishand expose metadata viaStateMetadata.MessengerAPI.Written by Cursor Bugbot for commit 241e6a0. This will update automatically on new commits. Configure here.