-
-
Notifications
You must be signed in to change notification settings - Fork 256
refactor: migrate {AccountActivity,BackendWebSocket}Service to @metamask/messenger
#6823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
{AccountActivity,BackendWebSocket}Service to @metamask/messenger
827f7f5 to
9a2a804
Compare
9a2a804 to
daec53e
Compare
Kriys94
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
Bug: Race Conditions in Test Asynchronous OperationsRemoving Additional Locations (6)
|
Explanation
This PR migrates
AccountActivityServiceandBackendWebSocketServiceto the new@metamask/messengermessage bus, as opposed to the one exported from@metamask/base-controller.References
Checklist
Note
Replaces base-controller messenger with @metamask/messenger across core-backend services, updates types/exports, tests, dependencies, and docs with breaking changes noted.
AccountActivityServiceandBackendWebSocketServiceto@metamask/messenger(Messenger) replacingRestrictedMessenger.delegate,publish/subscribe/callusage; adjust connection, subscription, and event handling accordingly.BackendWebSocketServiceAllowedActions/Events,AccountActivityServiceAllowedActions/Events,ACCOUNT_ACTIVITY_SERVICE_ALLOWED_ACTIONS/ EVENTS.anonymoustoincludeInDebugSnapshot.@metamask/base-controller; add@metamask/messengerand reference intsconfig.@metamask/profile-sync-controllerto^25.1.2.core_backend --> messenger; addeip_7702_internal_rpc_middleware --> controller_utils.Written by Cursor Bugbot for commit 1eef1b3. This will update automatically on new commits. Configure here.