Skip to content

Conversation

@Mrtenz
Copy link
Member

@Mrtenz Mrtenz commented Oct 16, 2025

Explanation

This moves eth-block-tracker from the merged-packages to the main packages folder.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

Note

Migrates @metamask/eth-block-tracker into packages, updates configs/lint/ownership, and bumps consumers to v13 with a breaking minimum Node.js 18.18.

  • Packages:
    • eth-block-tracker: Moved from merged-packages/ to packages/; updated tsconfig.*, test import paths (../test -> ../tests), and package metadata (homepage/bugs/keywords/files/scripts).
    • Breaking: Set engines to node ^18.18 || >=20; documented in CHANGELOG.md.
  • Consumers/Deps:
    • Bump @metamask/eth-block-tracker to ^13.0.0 in root, network-controller, transaction-controller, and user-operation-controller; update yarn.lock.
  • Build/Config:
    • Add packages/eth-block-tracker references to root tsconfig.json and tsconfig.build.json; add project references in network-controller tsconfig.*.
    • ESLint: add per-package override for packages/eth-block-tracker/**/*.ts and update eslint-warning-thresholds.json.
  • Ownership:
    • Add packages/eth-block-tracker to .github/CODEOWNERS and map metamask/eth-block-tracker in teams.json.

Written by Cursor Bugbot for commit 0c52794. This will update automatically on new commits. Configure here.

@socket-security
Copy link

socket-security bot commented Oct 16, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedundici-types@​6.19.81001007491100
Added@​metamask/​eth-block-tracker@​0.0.0-use.local100100100100100

View full report

@Mrtenz Mrtenz marked this pull request as ready for review October 16, 2025 17:44
@Mrtenz Mrtenz requested review from a team as code owners October 16, 2025 17:44
Copy link
Member

@rekmarks rekmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@Mrtenz Mrtenz merged commit b8756fc into main Oct 16, 2025
250 checks passed
@Mrtenz Mrtenz deleted the mrtenz/migrate-eth-block-tracker branch October 16, 2025 17:48
Mrtenz added a commit that referenced this pull request Oct 16, 2025
## Explanation

The `eth-block-tracker` changelog accidentally contained an invalid PR
number, which has been fixed in this PR.

## References

<!--
Are there any issues that this pull request is tied to?
Are there other links that reviewers should consult to understand these
changes better?
Are there client or consumer pull requests to adopt any breaking
changes?

For example:

* Fixes #12345
* Related to #67890
-->

## Checklist

- [ ] I've updated the test suite for new or updated code as appropriate
- [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or
updated code as appropriate
- [ ] I've communicated my changes to consumers by [updating changelogs
for packages I've
changed](https://github.com/MetaMask/core/tree/main/docs/contributing.md#updating-changelogs),
highlighting breaking changes as necessary
- [ ] I've prepared draft pull requests for clients and consumer
packages to resolve any breaking changes

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> Corrects PR numbers in `packages/eth-block-tracker/CHANGELOG.md` from
#7930 to #6865 for the Node.js minimum version change and monorepo
migration notes.
> 
> - **Changelog (`packages/eth-block-tracker/CHANGELOG.md`)**:
>   - Correct PR references from `#7930` to `#6865` for:
>     - The breaking change updating minimum Node.js version
>     - The migration to the `MetaMask/core` monorepo
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
caf93c0. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants