Skip to content

Conversation

@rekmarks
Copy link
Member

@rekmarks rekmarks commented Oct 16, 2025

Explanation

Finalizes the migration of @metamask/eth-json-rpc-middleware from its own repository to the core monorepo per "Phase C" of the migration process.

References

N/A

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

Note

Migrates @metamask/eth-json-rpc-middleware into /packages, updates build/lint/test configs and ownership, bumps Network Controller to ^20.0.0, and makes minor test/code fixes.

  • Packages:
    • @metamask/eth-json-rpc-middleware: Migrated into packages/ with new tsconfig*, jest.config.js (lowered coverage thresholds), updated package.json (homepage/bugs, scripts, keywords, engines ^18.18 || >=20, build flags), and added CHANGELOG.md (Node min bump; @metamask/eth-block-tracker -> ^13.0.0). Minor test/code tweaks (setTimeout callback style, await expect(...).toNeverResolve(), JSDoc param names, remove unused eslint-disable).
  • Consumers:
    • @metamask/network-controller: Bump @metamask/eth-json-rpc-middleware to ^20.0.0; add TS project references; update CHANGELOG.md.
  • Tooling/Config:
    • ESLint: Add per-package rules for packages/eth-json-rpc-middleware/**/*.ts; include **/test/** glob; add numerous warning thresholds for new files.
    • TypeScript: Add workspace refs in root tsconfig.json and tsconfig.build.json; remove merged-packages/... tsconfig.
    • Ownership/Teams: Update .github/CODEOWNERS and teams.json to include eth-json-rpc-middleware; adjust joint ownership entries.
    • Yarn constraints: Allow special license handling for @metamask/eth-json-rpc-middleware.

Written by Cursor Bugbot for commit 27f075f. This will update automatically on new commits. Configure here.

"test:watch": "NODE_OPTIONS=--experimental-vm-modules jest --watch"
},
"dependencies": {
"@metamask/eth-block-tracker": "^13.0.0",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was never released, and will in any case be restored prior to the next release of this package.

Comment on lines +23 to +26
branches: 67.25,
functions: 81.57,
lines: 79.71,
statements: 79.83,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverage changed due to different Jest version / config and/or Node.js version and/or other environment differences.

@socket-security
Copy link

socket-security bot commented Oct 16, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatedis-core-module@​2.15.1 ⏵ 2.16.167 +110082 +153100
Added@​metamask/​eth-json-rpc-middleware@​20.0.0991008096100

View full report

@rekmarks rekmarks marked this pull request as ready for review October 16, 2025 18:04
@rekmarks rekmarks requested review from a team as code owners October 16, 2025 18:04
@rekmarks rekmarks enabled auto-merge (squash) October 16, 2025 18:09
@rekmarks rekmarks merged commit 64f0777 into main Oct 16, 2025
251 checks passed
@rekmarks rekmarks deleted the rekm/eth-json-rpc-middleware-finalize-migration branch October 16, 2025 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants