-
-
Notifications
You must be signed in to change notification settings - Fork 252
chore: Migrate @metamask/eth-json-rpc-middleware to /packages
#6866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Migrate @metamask/eth-json-rpc-middleware to /packages
#6866
Conversation
| "test:watch": "NODE_OPTIONS=--experimental-vm-modules jest --watch" | ||
| }, | ||
| "dependencies": { | ||
| "@metamask/eth-block-tracker": "^13.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was never released, and will in any case be restored prior to the next release of this package.
| branches: 67.25, | ||
| functions: 81.57, | ||
| lines: 79.71, | ||
| statements: 79.83, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coverage changed due to different Jest version / config and/or Node.js version and/or other environment differences.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Explanation
Finalizes the migration of
@metamask/eth-json-rpc-middlewarefrom its own repository to the core monorepo per "Phase C" of the migration process.References
N/A
Checklist
Note
Migrates
@metamask/eth-json-rpc-middlewareinto/packages, updates build/lint/test configs and ownership, bumps Network Controller to^20.0.0, and makes minor test/code fixes.@metamask/eth-json-rpc-middleware: Migrated intopackages/with newtsconfig*,jest.config.js(lowered coverage thresholds), updatedpackage.json(homepage/bugs, scripts, keywords, engines^18.18 || >=20, build flags), and addedCHANGELOG.md(Node min bump;@metamask/eth-block-tracker->^13.0.0). Minor test/code tweaks (setTimeoutcallback style,await expect(...).toNeverResolve(), JSDoc param names, remove unused eslint-disable).@metamask/network-controller: Bump@metamask/eth-json-rpc-middlewareto^20.0.0; add TS project references; updateCHANGELOG.md.packages/eth-json-rpc-middleware/**/*.ts; include**/test/**glob; add numerous warning thresholds for new files.tsconfig.jsonandtsconfig.build.json; removemerged-packages/...tsconfig..github/CODEOWNERSandteams.jsonto includeeth-json-rpc-middleware; adjust joint ownership entries.@metamask/eth-json-rpc-middleware.Written by Cursor Bugbot for commit 27f075f. This will update automatically on new commits. Configure here.