Skip to content

Conversation

@bfullam
Copy link
Contributor

@bfullam bfullam commented Dec 16, 2025

Explanation

Minor bridge-controller bump for Tron fee calculation changes

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Bumps @metamask/bridge-controller to 64.2.0 (adds Tron fee limit passthrough) and propagates dependency/version updates to dependent packages and monorepo.

  • Release
    • Bump monorepo version to 725.0.0 in package.json.
  • Bridge Controller (@metamask/bridge-controller)
    • Version 64.2.0 with Tron snap fee limit passthrough.
    • Dependency bumps: @metamask/assets-controllers@^94.1.0, @metamask/transaction-controller@^62.7.0.
    • Update CHANGELOG.md links/entries.
  • Bridge Status Controller (@metamask/bridge-status-controller)
    • Version 64.2.0; depend on @metamask/bridge-controller@^64.2.0 and @metamask/transaction-controller@^62.7.0.
    • Update CHANGELOG.md links/entries.
  • Transaction Pay Controller (@metamask/transaction-pay-controller)
    • Update deps to @metamask/bridge-controller@^64.2.0 and @metamask/bridge-status-controller@^64.2.0.
    • Update CHANGELOG.md (Unreleased) to reflect bumps.
  • Tooling
    • Refresh yarn.lock to new controller versions.

Written by Cursor Bugbot for commit fa239dc. This will update automatically on new commits. Configure here.

@bfullam bfullam requested review from a team as code owners December 16, 2025 01:27
@bfullam bfullam enabled auto-merge December 16, 2025 01:36
ghgoodreau
ghgoodreau previously approved these changes Dec 16, 2025

### Added

- feat: add override functionality to remote feature flags ([#7271](https://github.com/MetaMask/core/pull/7271))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is needed as this just changes to tests for this package, is this true?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was automatically added by the release script and was failing the changelog check when I didn't include it. It's completely unrelated to my changes, though.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, it's still inaccurate though. If you take a look at that linked PR, it's clear that it doesn't add any feature to this package.

Copy link
Member

@Gudahtt Gudahtt Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have checks in place to ensure changes are documented alongside the PRs that introduce them, but it doesn't know how to differentiate dev-only changes from production code changes. When a PR has dev-only changes, the changelog script may re-introduce a change entry for it later because it doesn't know if it's been missed or not. You can use the no-changelog label to override that check when this happens.


- Bump `@metamask/assets-controllers` from `^93.1.0` to `^94.1.0` ([#7444](https://github.com/MetaMask/core/pull/7444), [#7488](https://github.com/MetaMask/core/pull/7488))
- Bump `@metamask/transaction-controller` from `^62.5.0` to `^62.7.0` ([#7430](https://github.com/MetaMask/core/pull/7430), [#7494](https://github.com/MetaMask/core/pull/7494))
- Add fee limit passthrough for Tron snap fee computation ([#7426](https://github.com/MetaMask/core/pull/7426))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this change not actually added in 64.1.0, is that why this was moved?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, exactly. This whole release is just because somehow the last release included the changelog entry but not the actual changes. Hoping to rectify that error with this release.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. Looks like this is a bug with how CI is configured in our merge queue.

We protect against release candidates bringing in unreviewed changes, but we don't protect against non-release PRs from documenting their changes under previous releases. Tricky.

@lwin-kyaw lwin-kyaw mentioned this pull request Dec 16, 2025
4 tasks
Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>
GeorgeGkas and others added 2 commits December 16, 2025 17:23
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
OGPoyraz
OGPoyraz previously approved these changes Dec 16, 2025
Comment on lines 221 to 222
[Unreleased]: https://github.com/MetaMask/core/compare/@metamask/transaction-pay-controller@10.6.0...HEAD
[10.6.0]: https://github.com/MetaMask/core/compare/@metamask/transaction-pay-controller@10.5.0...@metamask/transaction-pay-controller@10.6.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this part needs to be reverted as we are not publishing this controller.

@bfullam bfullam added this pull request to the merge queue Dec 16, 2025
Merged via the queue into main with commit 583ed6a Dec 16, 2025
285 checks passed
@bfullam bfullam deleted the release/725.0.0 branch December 16, 2025 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants