-
-
Notifications
You must be signed in to change notification settings - Fork 258
Release/725.0.0 #7509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release/725.0.0 #7509
Conversation
|
|
||
| ### Added | ||
|
|
||
| - feat: add override functionality to remote feature flags ([#7271](https://github.com/MetaMask/core/pull/7271)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is needed as this just changes to tests for this package, is this true?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was automatically added by the release script and was failing the changelog check when I didn't include it. It's completely unrelated to my changes, though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, it's still inaccurate though. If you take a look at that linked PR, it's clear that it doesn't add any feature to this package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have checks in place to ensure changes are documented alongside the PRs that introduce them, but it doesn't know how to differentiate dev-only changes from production code changes. When a PR has dev-only changes, the changelog script may re-introduce a change entry for it later because it doesn't know if it's been missed or not. You can use the no-changelog label to override that check when this happens.
|
|
||
| - Bump `@metamask/assets-controllers` from `^93.1.0` to `^94.1.0` ([#7444](https://github.com/MetaMask/core/pull/7444), [#7488](https://github.com/MetaMask/core/pull/7488)) | ||
| - Bump `@metamask/transaction-controller` from `^62.5.0` to `^62.7.0` ([#7430](https://github.com/MetaMask/core/pull/7430), [#7494](https://github.com/MetaMask/core/pull/7494)) | ||
| - Add fee limit passthrough for Tron snap fee computation ([#7426](https://github.com/MetaMask/core/pull/7426)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this change not actually added in 64.1.0, is that why this was moved?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, exactly. This whole release is just because somehow the last release included the changelog entry but not the actual changes. Hoping to rectify that error with this release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting. Looks like this is a bug with how CI is configured in our merge queue.
We protect against release candidates bringing in unreviewed changes, but we don't protect against non-release PRs from documenting their changes under previous releases. Tricky.
Co-authored-by: Frederik Bolding <frederik.bolding@gmail.com>
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
| [Unreleased]: https://github.com/MetaMask/core/compare/@metamask/transaction-pay-controller@10.6.0...HEAD | ||
| [10.6.0]: https://github.com/MetaMask/core/compare/@metamask/transaction-pay-controller@10.5.0...@metamask/transaction-pay-controller@10.6.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this part needs to be reverted as we are not publishing this controller.
Explanation
Minor bridge-controller bump for Tron fee calculation changes
References
Checklist
Note
Bumps
@metamask/bridge-controllerto64.2.0(adds Tron fee limit passthrough) and propagates dependency/version updates to dependent packages and monorepo.versionto725.0.0inpackage.json.@metamask/bridge-controller)64.2.0with Tron snap fee limit passthrough.@metamask/assets-controllers@^94.1.0,@metamask/transaction-controller@^62.7.0.CHANGELOG.mdlinks/entries.@metamask/bridge-status-controller)64.2.0; depend on@metamask/bridge-controller@^64.2.0and@metamask/transaction-controller@^62.7.0.CHANGELOG.mdlinks/entries.@metamask/transaction-pay-controller)@metamask/bridge-controller@^64.2.0and@metamask/bridge-status-controller@^64.2.0.CHANGELOG.md(Unreleased) to reflect bumps.yarn.lockto new controller versions.Written by Cursor Bugbot for commit fa239dc. This will update automatically on new commits. Configure here.