Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: @metamask/eth-json-rpc-provider@^3.0.2->^4.0.0 #247

Merged
merged 5 commits into from
Jun 13, 2024
Merged

deps: @metamask/eth-json-rpc-provider@^3.0.2->^4.0.0 #247

merged 5 commits into from
Jun 13, 2024

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Jun 12, 2024 •
edited
Loading

  • deps: Bump @metamask/eth-json-rpc-provider from ^3.0.2 to ^4.0.0.
    • devDeps: Bump @metamask/json-rpc-engine from ^8.0.2 to ^9.0.0.
  • Chore: Bump @metamask/ dependencies in lockfile

@socket-security Socket Security
Copy link

socket-security bot commented Jun 12, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/eth-json-rpc-provider@4.0.0 None 0 0 B
npm/@metamask/json-rpc-engine@9.0.0 None +2 361 kB metamaskbot
npm/@metamask/safe-event-emitter@3.1.1 None 0 24.1 kB lgbot
npm/@metamask/utils@8.5.0 Transitive: network +14 2.48 MB metamaskbot

🚮 Removed packages: npm/@metamask/eth-json-rpc-provider@3.0.2, npm/@metamask/json-rpc-engine@8.0.2, npm/@metamask/safe-event-emitter@3.0.0, npm/@metamask/utils@8.3.0

View full report↗︎

This was referenced Jun 12, 2024
Closed
Closed
@dependabot @legobeat
Bump @metamask/utils from 8.3.0 to 8.5.0
8f5675d 
Bumps [@metamask/utils](https://github.com/MetaMask/utils) from 8.3.0 to 8.5.0.
- [Release notes](https://github.com/MetaMask/utils/releases)
- [Changelog](https://github.com/MetaMask/utils/blob/main/CHANGELOG.md)
- [Commits](MetaMask/utils@v8.3.0...v8.5.0)

---
updated-dependencies:
- dependency-name: "@metamask/utils"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@legobeat legobeat mentioned this pull request Jun 12, 2024
Closed
@dependabot @legobeat
Bump @metamask/rpc-errors from 6.2.1 to 6.3.0
8f932f3 
Bumps [@metamask/rpc-errors](https://github.com/MetaMask/rpc-errors) from 6.2.1 to 6.3.0.
- [Release notes](https://github.com/MetaMask/rpc-errors/releases)
- [Changelog](https://github.com/MetaMask/rpc-errors/blob/main/CHANGELOG.md)
- [Commits](MetaMask/rpc-errors@v6.2.1...v6.3.0)

---
updated-dependencies:
- dependency-name: "@metamask/rpc-errors"
  dependency-type: indirect
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@legobeat legobeat mentioned this pull request Jun 12, 2024
Closed
@dependabot @legobeat
Bump @metamask/safe-event-emitter from 3.0.0 to 3.1.1
ecdc1f8 
Bumps [@metamask/safe-event-emitter](https://github.com/MetaMask/safe-event-emitter) from 3.0.0 to 3.1.1.
- [Release notes](https://github.com/MetaMask/safe-event-emitter/releases)
- [Changelog](https://github.com/MetaMask/safe-event-emitter/blob/main/CHANGELOG.md)
- [Commits](MetaMask/safe-event-emitter@v3.0.0...v3.1.1)

---
updated-dependencies:
- dependency-name: "@metamask/safe-event-emitter"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@legobeat legobeat mentioned this pull request Jun 12, 2024
Closed
@legobeat legobeat marked this pull request as ready for review June 12, 2024 22:36
@legobeat legobeat requested a review from a team as a code owner June 12, 2024 22:37
@socket-security Socket Security
Copy link

socket-security bot commented Jun 12, 2024 •
edited
Loading

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/@metamask/safe-event-emitter@3.1.1

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

@legobeat
Copy link
Contributor Author 

@SocketSecurity ignore npm/@metamask/safe-event-emitter@3.1.1
@SocketSecurity ignore npm/@metamask/safe-event-emitter@3.0.0

new author ok (though only 3.1.1) is actually used here

@legobeat legobeat requested a review from mcmire June 12, 2024 22:38
@legobeat legobeat mentioned this pull request Jun 12, 2024
Merged
1 task
@legobeat legobeat requested a review from kumavis June 12, 2024 22:40
mcmire
mcmire approved these changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@legobeat legobeat merged commit 29ec04a into MetaMask:main Jun 13, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbrans dbrans dbrans approved these changes

@mcmire mcmire mcmire approved these changes

@kumavis kumavis Awaiting requested review from kumavis

Assignees
No one assigned
Labels
None yet
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@legobeat @mcmire @dbrans