Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: json-rpc-engine@^6.0.0 -> @metamask/json-rpc-engine@^7.1.0 #104

Merged
merged 3 commits into from
Sep 22, 2023

Conversation

@legobeat legobeat requested a review from a team as a code owner September 6, 2023 03:46
@legobeat legobeat added the dependencies Pull requests that update a dependency file label Sep 6, 2023
@legobeat legobeat marked this pull request as draft September 6, 2023 03:46
@legobeat legobeat force-pushed the deps-metamask-json-rpc-engine branch from 6f86461 to 2c651b8 Compare September 6, 2023 03:51
This was referenced Sep 6, 2023
@socket-security
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@metamask/eth-json-rpc-middleware 11.0.1 network +9 1.44 MB metamaskbot

🚮 Removed packages: eth-json-rpc-middleware@9.0.1

@socket-security
Copy link

socket-security bot commented Sep 8, 2023

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: @metamask/eth-json-rpc-provider@1.0.1, crc-32@1.2.2, @metamask/eth-json-rpc-middleware@11.0.1

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

@legobeat
Copy link
Contributor Author

legobeat commented Sep 8, 2023

@SocketSecurity ignore @metamask/eth-json-rpc-provider@1.0.1
@SocketSecurity ignore @metamask/eth-json-rpc-middleware@11.0.1

@legobeat
Copy link
Contributor Author

legobeat commented Sep 8, 2023

@SocketSecurity ignore crc-32@1.2.2

unmaintained ok

@legobeat legobeat force-pushed the deps-metamask-json-rpc-engine branch from fcefabd to b41ab0a Compare September 22, 2023 03:17
@legobeat legobeat marked this pull request as ready for review September 22, 2023 03:20
@legobeat legobeat requested review from a team and Gudahtt September 22, 2023 03:22
@legobeat legobeat merged commit dd4731f into MetaMask:main Sep 22, 2023
@legobeat legobeat deleted the deps-metamask-json-rpc-engine branch September 23, 2023 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants