Adding handling for null block in getBlocksForRange #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpuri
commented
Apr 29, 2022
kumavis
previously approved these changes
May 3, 2022
mcmire
previously approved these changes
May 3, 2022
getBlocksForRange.js
Outdated
| ); | ||
| } | ||
| } | ||
| throw new Error(`Block not found for params: ${params}`); |
There was a problem hiding this comment.
[nit] The params in the error message seem like they get oversimplified. What about JSON.stringify(params)?
Merged
|
i think the actual fix is here #83 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MetaMask/metamask-extension#10550
PR fixes issue that
getBlocksForRangecan return null block. The approach takes for the fix is as details here: