Add source header #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danfinlay
reviewed
Jan 17, 2019
| @@ -110,11 +113,15 @@ function fetchConfigFromReq({ network, req }) { | |||
| fetchParams.method = 'POST' | |||
| fetchParams.headers = { | |||
| 'Accept': 'application/json', | |||
| 'Content-Type': 'application/json' | |||
| 'Content-Type': 'application/json', | |||
| [source]: requestOrigin | |||
There was a problem hiding this comment.
I guess my big question about adding a new header: Does this cause a pre-flight, doubling our load on Infura? I'm not a header pre-flight expert, that would really be my top question for @kumavis.
There was a problem hiding this comment.
@jennypollack @danfinlay if you inspect the network requests on the BG and you see a bunch of OPTIONS requests right before the POST then the answer is yes.
There was a problem hiding this comment.
just spent some time clocking network activity between my branch and the current release (5.3.1) for mainnet and rinkeby and the numbers don't lead me to believe that there is a pre-flight. i'm also not seeing any OPTIONS requests before the POST as @brunobar79 mentioned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.