Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update InfuraJsonRpcSupportedNetwork with supported networks #69

Merged
merged 2 commits into from
Jan 25, 2023
Merged

Update InfuraJsonRpcSupportedNetwork with supported networks #69

merged 2 commits into from
Jan 25, 2023

Conversation

mikesposito
Copy link
Member

@mikesposito mikesposito commented Jan 23, 2023 •
edited
Loading

This PR adds support for Infura-supported networks on type InfuraJsonRpcSupportedNetwork, according to the supported Infura network list.

The PR also removes deprecated networks.

This is also needed for #16580

@mikesposito mikesposito requested a review from a team as a code owner January 23, 2023 14:57
mcmire
mcmire previously approved these changes Jan 23, 2023
View reviewed changes
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Gudahtt
Gudahtt previously approved these changes Jan 23, 2023
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

We should consider updating this list to remove the three old testnets as well

@Gudahtt
Copy link
Member

Gudahtt commented Jan 23, 2023

I was able to find a more complete list of subdomains supported by Infura here: https://docs.infura.io/infura/reference/network-endpoints#ethereum

@mikesposito mikesposito dismissed stale reviews from Gudahtt and mcmire via 29bd6d2 January 24, 2023 12:34
@mikesposito
Copy link
Member Author

I was able to find a more complete list of subdomains supported by Infura here: https://docs.infura.io/infura/reference/network-endpoints#ethereum

Thanks @Gudahtt! I updated our type with all JSON-RPC subdomains supported (IPFS ignored).

Gudahtt
Gudahtt approved these changes Jan 24, 2023
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

mcmire
mcmire approved these changes Jan 24, 2023
View reviewed changes
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Make sure to update the commit message before you merge as this is no longer just adding Sepolia :)

@mikesposito mikesposito changed the title Add sepolia to InfuraJsonRpcSupportedNetwork Update InfuraJsonRpcSupportedNetwork with supported networks Jan 25, 2023
@mikesposito mikesposito merged commit 4a3ac88 into MetaMask:main Jan 25, 2023
@mikesposito mikesposito deleted the feat/add-sepolia-to-supported-networks-type branch January 25, 2023 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

@mcmire mcmire mcmire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikesposito @Gudahtt @mcmire