Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for eth_sign #320

Merged
merged 2 commits into from
Jul 26, 2024
Merged

Remove support for eth_sign #320

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fbc2bdd
remove eth_sign
adonesky1 Jul 18, 2024
cfe8336
Merge branch 'main' into ad/remove-eth_sign
adonesky1 Jul 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 0 additions & 36 deletions src/wallet.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,10 +55,6 @@
address: string,
req: JsonRpcRequest,
) => Promise<string>;
processEthSignMessage?: (
msgParams: MessageParams,
req: JsonRpcRequest,
) => Promise<string>;
processPersonalMessage?: (
msgParams: MessageParams,
req: JsonRpcRequest,
Expand Down Expand Up @@ -92,7 +88,6 @@
getAccounts,
processDecryptMessage,
processEncryptionPublicKey,
processEthSignMessage,
processPersonalMessage,
processTransaction,
processSignTransaction,
Expand All @@ -113,7 +108,6 @@
eth_sendTransaction: createAsyncMiddleware(sendTransaction),
eth_signTransaction: createAsyncMiddleware(signTransaction),
// message signatures
eth_sign: createAsyncMiddleware(ethSign),
eth_signTypedData: createAsyncMiddleware(signTypedData),
eth_signTypedData_v3: createAsyncMiddleware(signTypedDataV3),
eth_signTypedData_v4: createAsyncMiddleware(signTypedDataV4),
Expand Down Expand Up @@ -195,36 +189,6 @@
//
// message signatures
//

async function ethSign(
req: JsonRpcRequest,
res: PendingJsonRpcResponse<Json>,
): Promise<void> {
if (!processEthSignMessage) {
throw rpcErrors.methodNotSupported();
}
if (
!req?.params ||
!Array.isArray(req.params) ||
!(req.params.length >= 2)
) {
throw rpcErrors.invalidInput();
}

const params = req.params as [string, string, Record<string, string>?];
const address: string = await validateAndNormalizeKeyholder(params[0], req);
const message = params[1];
const extraParams = params[2] || {};
const msgParams: MessageParams = {
...extraParams,
from: address,
data: message,
signatureMethod: 'eth_sign',
};

res.result = await processEthSignMessage(msgParams, req);
}

async function signTypedData(
req: JsonRpcRequest,
res: PendingJsonRpcResponse<Json>,
Expand Down Expand Up @@ -462,7 +426,7 @@
*
* @param address - The address to validate and normalize.
* @param req - The request object.
* @returns {string} - The normalized address, if valid. Otherwise, throws

Check warning on line 429 in src/wallet.ts

View workflow job for this annotation

GitHub Actions / Build, lint, and test / Lint (18.x) 

There must be no hyphen before @returns description

Check warning on line 429 in src/wallet.ts

View workflow job for this annotation

GitHub Actions / Build, lint, and test / Lint (20.x) 

There must be no hyphen before @returns description

Check warning on line 429 in src/wallet.ts

View workflow job for this annotation

GitHub Actions / Build, lint, and test / Lint (22.x) 

There must be no hyphen before @returns description
* an error
*/
async function validateAndNormalizeKeyholder(
Expand Down
Loading