Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: regex match condition for primary type #353

Merged
merged 6 commits into from
Dec 19, 2024
Merged

fix: regex match condition for primary type #353

merged 6 commits into from
Dec 19, 2024

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Dec 19, 2024

This PR is in continuation of the previous one: #350

It fixes a condition while validating primary type of types signatures.

@jpuri jpuri requested a review from a team as a code owner December 19, 2024 10:08
OGPoyraz
OGPoyraz previously approved these changes Dec 19, 2024
src/utils/common.test.ts Outdated Show resolved Hide resolved
Gudahtt
Gudahtt previously approved these changes Dec 19, 2024
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Co-authored-by: Mark Stacey <markjstacey@gmail.com>
@jpuri jpuri merged commit 73db8a7 into main Dec 19, 2024
19 checks passed
@jpuri jpuri deleted the correct_condition branch December 19, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants