Fix package export and files manifest property
#70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main export of the package was broken in #60 when the source files were moved into the `src` directory, because the path of the `main` property was not updated accordingly. This updates `main` to point at the new location of the `block-ref` module. Any modules referenced by file will still be in different locations now (e.g. `require('eth-json-rpc-middleware/block-ref`) will have to be changed to `require('eth-json-rpc-middleware/src/block-ref`), so #60 will still need to be treated as a breaking change. But at least the main export works now. The `files` property of the manifest was also broken in #60. It has been updated to correctly reference all of the JavaScript modules that should be published.
Gudahtt
force-pushed
the
fix-package-export
branch
from
e893955 to
4301c35
Compare
Gudahtt
changed the title
files manifest property
rekmarks
approved these changes
Feb 5, 2021
sambacha
pushed a commit
to sambacha/eth-json-rpc-middleware
that referenced
this pull request
Mar 22, 2021
The main export of the package was broken in MetaMask#60 when the source files were moved into the `src` directory, because the path of the `main` property was not updated accordingly. This updates `main` to point at the new location of the `block-ref` module. Any modules referenced by file will still be in different locations now (e.g. `require('eth-json-rpc-middleware/block-ref`) will have to be changed to `require('eth-json-rpc-middleware/src/block-ref`), so MetaMask#60 will still need to be treated as a breaking change. But at least the main export works now. The `files` property of the manifest was also broken in MetaMask#60. It has been updated to correctly reference all of the JavaScript modules that should be published.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main export of the package was broken in #60 when the source files were moved into the
srcdirectory, because the path of themainproperty was not updated accordingly. This updatesmainto point at the new location of theblock-refmodule.Any modules referenced by file will still be in different locations now (e.g.
require('eth-json-rpc-middleware/block-ref) will have to be changed torequire('eth-json-rpc-middleware/src/block-ref), so #60 will still need to be treated as a breaking change. But at least the main export works now.The
filesproperty of the manifest was also broken in #60. It has been updated to correctly reference all of the JavaScript modules that should be published.