Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor exports #81

Merged
merged 1 commit into from
Mar 25, 2021
Merged

Refactor exports #81

merged 1 commit into from
Mar 25, 2021

Conversation

rekmarks
Copy link
Member

@rekmarks rekmarks commented Mar 25, 2021 •
edited
Loading

  • Use named exports only
  • Add index.ts that re-exports everything except cache-utils, which is only used internally
  • Move cache-utils to separate utils folder to emphasize that it's different from the rest of the source files

@rekmarks rekmarks requested a review from a team as a code owner March 25, 2021 21:58
@rekmarks rekmarks marked this pull request as draft March 25, 2021 22:09
@rekmarks
Add named exports, index.ts
24071bf 
* Move cache-utils to separate folder
@rekmarks rekmarks changed the title Refactor exports, update eslint and TypeScript configs Refactor exports Mar 25, 2021
@rekmarks rekmarks marked this pull request as ready for review March 25, 2021 23:44
@rekmarks rekmarks requested a review from NiranjanaBinoy March 25, 2021 23:44
NiranjanaBinoy
NiranjanaBinoy approved these changes Mar 25, 2021
View reviewed changes
Copy link
Contributor

@NiranjanaBinoy NiranjanaBinoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rekmarks rekmarks merged commit fc1fd5d into main Mar 25, 2021
@rekmarks rekmarks deleted the exports-refactor branch March 25, 2021 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NiranjanaBinoy NiranjanaBinoy NiranjanaBinoy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rekmarks @NiranjanaBinoy