deps: Switch from json-rpc-engine to @metamask/json-rpc-engine

[legobeat]

• Switch from json-rpc-engine to renamed and maintained @metamask/json-rpc-engine
  • Add @metamask/utils for types moved there
• Bump @metamask/safe-event-emitter from ^2.0.0 to ^3.0.0.

This is related to #14 but I don't think either should be blocking the other.

[socket-security]

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages	Version	New capabilities	Transitives	Size	Publisher
@metamask/json-rpc-engine	7.0.0	network	+17	4.1 MB	metamaskbot
@metamask/safe-event-emitter	3.0.0	None	+0	8.07 kB	gudahtt
@metamask/utils	5.0.2	network	+15	3.92 MB	metamaskbot

🚮 Removed packages: json-rpc-engine@6.1.0

[socket-security]

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: @metamask/safe-event-emitter@3.0.0, @ethereumjs/common@3.2.0, @metamask/json-rpc-engine@7.0.0, @metamask/utils@5.0.2, superstruct@1.0.3, micro-ftch@0.3.1, @types/ms@0.7.31, crc-32@1.2.2, @scure/base@1.1.1

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

[legobeat]

@SocketSecurity ignore @metamask/safe-event-emitter@3.0.0
@SocketSecurity ignore @ethereumjs/common@3.2.0
@SocketSecurity ignore @metamask/json-rpc-engine@7.0.0
@SocketSecurity ignore @metamask/utils@5.0.2
@SocketSecurity ignore superstruct@1.0.3
@SocketSecurity ignore micro-ftch@0.3.1
@SocketSecurity ignore @types/ms@0.7.31
@SocketSecurity ignore crc-32@1.2.2
@SocketSecurity ignore @scure/base@1.1.1

[mcmire]

Looks good!

[mcmire]

Nice, this is much better.

[mcmire]

@legobeat It looks like this is causing build failures when upgrading core: MetaMask/core#1547. I missed that the types got changed in @metamask/json-rpc-engine and that affected this package too. So in hindsight, it appears this should have been released as a breaking change. Should we deprecate 1.0.1 and re-release it as 2.0.0? If so I can reach out to the appropriate people.

[mcmire]

Another update that came along with bumping json-rpc-engine is that this package now requires Node 16, as evidenced here: MetaMask/eth-block-tracker#167

[Gudahtt]

Should we deprecate 1.0.1 and re-release it as 2.0.0? If so I can reach out to the appropriate people.

Yes, this sounds appropriate

[legobeat]

@legobeat It looks like this is causing build failures when upgrading core: MetaMask/core#1547. I missed that the types got changed in @metamask/json-rpc-engine and that affected this package too. So in hindsight, it appears this should have been released as a breaking change. Should we deprecate 1.0.1 and re-release it as 2.0.0? If so I can reach out to the appropriate people.

Dang, should have left it at #17. Yes, sounds right.

Perhaps something like https://github.com/devoto13/yarn-plugin-engines is worth considering (until yarnpkg/berry#1177)

[legobeat]

Retracted in #19
Follow-up in #20