Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix constructor options interface name #25

Merged
merged 1 commit into from
Jan 10, 2021
Merged

Fix constructor options interface name #25

merged 1 commit into from
Jan 10, 2021

Conversation

rekmarks
Copy link
Member

Provider -> MethodRegistryArgs

@rekmarks rekmarks requested a review from a team as a code owner January 10, 2021 19:56
astarinmymind
astarinmymind approved these changes Jan 10, 2021
View reviewed changes
Copy link
Contributor

@astarinmymind astarinmymind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@astarinmymind astarinmymind self-requested a review January 10, 2021 20:00
@rekmarks rekmarks merged commit b5c928b into main Jan 10, 2021
@rekmarks rekmarks deleted the type-fixup branch January 10, 2021 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astarinmymind astarinmymind Awaiting requested review from astarinmymind

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rekmarks @astarinmymind