Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unit tests #27

Merged
merged 4 commits into from
Jan 13, 2021
Merged

Fix unit tests #27

merged 4 commits into from
Jan 13, 2021

Conversation

rekmarks
Copy link
Member

The unit tests make requests to Infura. This package was using the deprecated (removed?) Infura v1 API. This PR adds the rc dependency such that developers can add their Infura API keys for tests. It also adds the creation of an rc file for CI.

@rekmarks rekmarks requested a review from a team as a code owner January 13, 2021 06:54
@rekmarks rekmarks mentioned this pull request Jan 13, 2021
Merged
@rekmarks
Copy link
Member Author

Notice how tests are failing for #26 at the moment.

Gudahtt
Gudahtt reviewed Jan 13, 2021
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is better than failing tests, but it's still not great to be hitting Infura in unit tests 😬. What would it take to replace this with ganache instead? We'd probably need to deploy this method registry contract I'm guessing.

test/index.js Outdated Show resolved Hide resolved
astarinmymind
astarinmymind previously approved these changes Jan 13, 2021
View reviewed changes
Copy link
Contributor

@astarinmymind astarinmymind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Gudahtt
Gudahtt approved these changes Jan 13, 2021
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rekmarks rekmarks merged commit 25cfa3f into main Jan 13, 2021
@rekmarks rekmarks deleted the fix-tests branch January 13, 2021 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

@astarinmymind astarinmymind Awaiting requested review from astarinmymind

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rekmarks @Gudahtt @astarinmymind