Bugfix/afqdn check (#6891)

* Added logic to convert afqdn * Added test case for afqdn * Version bump - convert afqdn to fqdn before testing domain against lists * Correct variable name
MetaMask · Mar 22, 2022 · e58ead2 · e58ead2
1 parent 3568777
commit e58ead2
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "eth-phishing-detect",
-  "version": "1.1.15",
+  "version": "1.1.16",
   "description": "Utility for detecting phishing domains targeting Ethereum users",
   "main": "src/index.js",
   "scripts": {

diff --git a/src/detector.js b/src/detector.js
@@ -11,7 +11,11 @@ class PhishingDetector {
   }
 
   check (domain) {
-    const source = domainToParts(domain)
+    let fqdn = domain.substring(domain.length - 1) === "." 
+      ? domain.slice(0, -1)
+      : domain;
+
+    const source = domainToParts(fqdn)
 
     // if source matches whitelist domain (or subdomain thereof), PASS
     const whitelistMatch = matchPartsAgainstList(source, this.whitelist)

diff --git a/test/index.js b/test/index.js
@@ -51,6 +51,7 @@ function startTests () {
       "metamask.com",
       "wallet-ethereum.net",
       "etherclassicwallet.com",
+      "wallet-ethereum.net." //Test for absolute fully-qualified domain name
     ])
 
     // whitelist