Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TypedDataUtils.hashType tests #171

Merged
merged 1 commit into from
Aug 16, 2021
Merged

Add TypedDataUtils.hashType tests #171

merged 1 commit into from
Aug 16, 2021

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Aug 11, 2021

This function should now be comprehensively tested. These tests mirror the TypedDataUtils.encodeType tests. Any uses of hashType in the older signature tests have been removed, as they are now redundant.

@Gudahtt
Copy link
Member Author

Gudahtt commented Aug 11, 2021

This depends upon #167

@Gudahtt Gudahtt changed the base branch from add-hash-struct-tests to add-encode-type-tests August 11, 2021 23:52
src/index.test.ts Outdated Show resolved Hide resolved
rekmarks
rekmarks previously approved these changes Aug 15, 2021
Copy link
Member

@rekmarks rekmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vimdiff to the rescue 😌

LGTM!

@rekmarks
Copy link
Member

I made the same change as I did in #167, FYI.

Base automatically changed from add-encode-type-tests to main August 16, 2021 11:58
@Gudahtt Gudahtt marked this pull request as ready for review August 16, 2021 19:05
@Gudahtt Gudahtt requested a review from a team as a code owner August 16, 2021 19:05
@Gudahtt
Copy link
Member Author

Gudahtt commented Aug 16, 2021

This has been rebased to resolve conflicts

This function should now be comprehensively tested. These tests mirror
the `TypedDataUtils.encodeType` tests. Any uses of `hashType` in the
older signature tests have been removed, as they are now redundant.
Copy link
Member

@rekmarks rekmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt Gudahtt merged commit ae3653d into main Aug 16, 2021
@Gudahtt Gudahtt deleted the add-hash-type-tests branch August 16, 2021 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants