Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add concatSig docs and unit tests #177

Merged
merged 1 commit into from
Aug 16, 2021
Merged

Add concatSig docs and unit tests #177

merged 1 commit into from
Aug 16, 2021

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Aug 12, 2021

Inline documentation and unit tests have been added for the concatSig function. All novel cases I could think of that were type-compliant have been tested.

@Gudahtt Gudahtt requested a review from a team as a code owner August 12, 2021 21:37
rekmarks
rekmarks previously approved these changes Aug 15, 2021
Copy link
Member

@rekmarks rekmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Inline documentation and unit tests have been added for the `concatSig`
function. All novel cases I could think of that were type-compliant
have been tested.
@Gudahtt
Copy link
Member Author

Gudahtt commented Aug 16, 2021

This has been rebased to resolve conflicts

Copy link
Member

@rekmarks rekmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt Gudahtt merged commit c81c99a into main Aug 16, 2021
@Gudahtt Gudahtt deleted the add-concat-sig-tests branch August 16, 2021 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants