Add docs and tests for normalize
#178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rekmarks
requested changes
Aug 15, 2021
There was a problem hiding this comment.
I imagine the purpose of the object test case is to prove to ourselves that inputs that are neither strings nor numbers will be rejected. That being the case, I think we should either note that, or just test a bunch of primitives as well, perhaps by iterating over an array of bad inputs.
Gudahtt
commented
Aug 16, 2021
Gudahtt
force-pushed
the
add-normalize-tests
branch
from
607da16
to
d8ba35e
Compare
|
Good idea! I've added tests for all primitive types. I caught some unexpected behaviour for |
Inline documentation and tests have been added for the `normalize` function. Only one test was added; the rest were pre-existing. They were grouped together and updated to match our typical testing conventions.
Gudahtt
force-pushed
the
add-normalize-tests
branch
from
d8ba35e
to
4473e93
Compare
rekmarks
reviewed
Aug 16, 2021
rekmarks
reviewed
Aug 16, 2021
rekmarks
reviewed
Aug 16, 2021
rekmarks
reviewed
Aug 16, 2021
Gudahtt
commented
Aug 16, 2021
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
rekmarks
approved these changes
Aug 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inline documentation and tests have been added for the
normalizefunction. Only one test was added; the rest were pre-existing. They were grouped together and updated to match our typical testing conventions.