-
-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs and tests for normalize
#178
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I imagine the purpose of the object
test case is to prove to ourselves that inputs that are neither strings nor numbers will be rejected. That being the case, I think we should either note that, or just test a bunch of primitives as well, perhaps by iterating over an array of bad inputs.
607da16
to
d8ba35e
Compare
Good idea! I've added tests for all primitive types. I caught some unexpected behaviour for |
Inline documentation and tests have been added for the `normalize` function. Only one test was added; the rest were pre-existing. They were grouped together and updated to match our typical testing conventions.
d8ba35e
to
4473e93
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it actually LGTM!
Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Inline documentation and tests have been added for the
normalize
function. Only one test was added; the rest were pre-existing. They were grouped together and updated to match our typical testing conventions.