Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inline docs for all public functions #181

Merged
merged 4 commits into from
Aug 17, 2021
Merged

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Aug 17, 2021

All public functions now have inline documentation. Some of these descriptions are rather sparse, but it's a start. We can improve them later.

@Gudahtt Gudahtt requested a review from a team as a code owner August 17, 2021 12:37
All public functions now have inline documentation. Some of these
descriptions are rather sparse, but it's a start. We can improve them
later.
@Gudahtt Gudahtt force-pushed the add-missing-api-documentation branch from d254dd4 to 6223429 Compare August 17, 2021 12:38
Copy link
Member

@rekmarks rekmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much-needed!

src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
Gudahtt and others added 3 commits August 17, 2021 14:29
Co-authored-by: Erik Marks <25517051+rekmarks@users.noreply.github.com>
Co-authored-by: Erik Marks <25517051+rekmarks@users.noreply.github.com>
Copy link
Member

@rekmarks rekmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt Gudahtt merged commit c53e2b8 into main Aug 17, 2021
@Gudahtt Gudahtt deleted the add-missing-api-documentation branch August 17, 2021 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants