Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add solidity types to schema #189

Merged
merged 3 commits into from
Aug 19, 2021
Merged

Add solidity types to schema #189

merged 3 commits into from
Aug 19, 2021

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Aug 19, 2021

The solidity types supported by EIP-712 have been added to the typed message JSON schema.

This was originally proposed in #31; see there for more details.

@Gudahtt Gudahtt requested a review from a team as a code owner August 19, 2021 13:07
Copy link
Member

@rekmarks rekmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt Gudahtt merged commit ec0134f into main Aug 19, 2021
@Gudahtt Gudahtt deleted the add-solidity-types-to-schema branch August 19, 2021 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants