This repository has been archived by the owner on Oct 7, 2024. It is now read-only.
Remove ethereum-tx package
#79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This package was partially replaced by it's successor `@ethereumjs/tx` in #61, but was left around for the unit tests to ensure the keyring was compatible with both versions. Now that we have moved away from using `ethereum-tx` in in MetaMask itself, we don't really need to keep two versions of the same package around anymore.
brad-decker
approved these changes
Jul 8, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This package was partially replaced by it's successor
@ethereumjs/txin #61, but was left around for the unit tests to ensure the keyring was compatible with both versions. Now that we have moved away from usingethereum-txin in MetaMask itself, we don't really need to keep two versions of the same package around anymore.