Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add test-case for preserving precision in stringifyBalance #122

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Feb 5, 2024

The handling of zeros in parseBalance seemed like it could use some explicit test-case to minimize possibility of future regression

@legobeat legobeat marked this pull request as ready for review February 6, 2024 00:40
@legobeat legobeat requested a review from a team as a code owner February 6, 2024 00:40
@legobeat legobeat force-pushed the test-trailing-zeros branch from c85843f to a32f3e4 Compare February 6, 2024 00:40
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

@legobeat legobeat force-pushed the test-trailing-zeros branch from a32f3e4 to 46e7cfa Compare February 6, 2024 21:14
@legobeat legobeat merged commit b5f8d3c into MetaMask:main Feb 6, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants