Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

devDeps: upgrade tape, remove web3-provider-engine #89

Merged
merged 2 commits into from
Dec 13, 2022
Merged

devDeps: upgrade tape, remove web3-provider-engine #89

merged 2 commits into from
Dec 13, 2022

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Dec 12, 2022 •
edited
Loading

  • upgrade tape
  • remove unused devDependency web3-provider-engine

@legobeat legobeat force-pushed the devdeps-tape branch 2 times, most recently from 88dc74d to cad2b99 Compare December 12, 2022 23:12
@legobeat legobeat marked this pull request as ready for review December 12, 2022 23:12
@legobeat legobeat requested a review from a team as a code owner December 12, 2022 23:12
@legobeat legobeat requested a review from mcmire December 12, 2022 23:37
@legobeat legobeat changed the title devDeps: upgrade tape devDeps: upgrade tape, remove web3-provider-engine Dec 12, 2022
@legobeat legobeat mentioned this pull request Dec 13, 2022
Closed
Gudahtt
Gudahtt approved these changes Dec 13, 2022
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@legobeat legobeat merged commit e9395ac into MetaMask:main Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

@mcmire mcmire Awaiting requested review from mcmire

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@legobeat @Gudahtt