This repository has been archived by the owner on Oct 7, 2024. It is now read-only.
Added support for signing hex messages on Trezor. #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onnect#216 in Trezor for Metamask
|
Hey @sidsverma thanks for your PR! Unfortunately the way you did it it won't work since we were already getting the message as HEX and with your code it would break the current working implementation. I have a working fix on #16, which will be merged in soon |
|
Thanks for taking this up @brunobar79. Any timeline ideas as to when it will go live with Metamask? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supporting trezor/connect#216 in Trezor for Metamask.