This repository has been archived by the owner on Oct 7, 2024. It is now read-only.
Add public key check to prevent freezing. #155
+56
−51
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Fixes MetaMask/metamask-extension#12967
When the selected account on MetaMask is changed, the public key provided by MetaMask will differ from the one that the TrezorKeyring remembers. As a result, it will search for the address in the incorrect address space and eventually fall into a nearly infinite loop.
To fix this issue, I implemented a public key check. To do this, I made the following changes:
Pre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Board
label.In this case, a QA Engineer approval will be be required.