Skip to content
This repository has been archived by the owner on Oct 7, 2024. It is now read-only.

Rename package to use @metamask scope #160

Merged
merged 3 commits into from
Feb 8, 2023
Merged

Rename package to use @metamask scope #160

merged 3 commits into from
Feb 8, 2023

Conversation

mikesposito
Copy link
Member

@mikesposito mikesposito commented Feb 7, 2023

The package has been renamed to be under @metamask scope.
The property publishConfig has been added as it is required to publish packages under workspaces.
An Installation section has been added to the README as well.

Resolves #158

@mikesposito mikesposito requested a review from a team as a code owner February 7, 2023 14:00
@socket-security
Copy link

Socket Security Pull Request Report

Dependency issues detected. If you merge this pull request, you will not be alerted to the instances of these issues again.

📜 Install scripts

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Package Script field Source
blake-hash@2.0.0 (added) install package.json via @trezor/connect-web@9.0.6
keccak@3.0.3 (added) install package.json via @trezor/connect-plugin-ethereum@9.0.0, ethereumjs-tx@1.3.7
secp256k1@4.0.3 (added) install package.json via @trezor/connect-plugin-ethereum@9.0.0, ethereumjs-tx@1.3.7
tiny-secp256k1@1.1.6 (added) install package.json via @trezor/connect-web@9.0.6
protobufjs@6.11.3 (added) postinstall package.json via @trezor/connect-web@9.0.6
Pull request report summary
Issue Status
Install scripts ⚠️ 5 issues
Native code ✅ 0 issues
Bin script confusion ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues
Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@2.4.2

  • @SocketSecurity ignore blake-hash@2.0.0
  • @SocketSecurity ignore keccak@3.0.3
  • @SocketSecurity ignore secp256k1@4.0.3
  • @SocketSecurity ignore tiny-secp256k1@1.1.6
  • @SocketSecurity ignore protobufjs@6.11.3

Powered by socket.dev

Copy link

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikesposito mikesposito merged commit a49d5e7 into MetaMask:main Feb 8, 2023
@mikesposito mikesposito deleted the chore/rename-package-workspace branch February 8, 2023 07:20
@adonesky1 adonesky1 mentioned this pull request Feb 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename package to use @metamask scope
2 participants