Skip to content
This repository has been archived by the owner on Oct 7, 2024. It is now read-only.

deps: hdkey@0.8.0->^2.1.0 #190

Merged
merged 2 commits into from
Oct 7, 2023
Merged

deps: hdkey@0.8.0->^2.1.0 #190

merged 2 commits into from
Oct 7, 2023

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Oct 3, 2023

@socket-security
Copy link

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
hdkey 0.8.0...2.1.0 None +0/-4 15.3 kB ryanzim

@legobeat legobeat marked this pull request as ready for review October 3, 2023 04:21
@legobeat legobeat requested a review from a team as a code owner October 3, 2023 04:21
@legobeat legobeat mentioned this pull request Oct 3, 2023
Merged
@legobeat legobeat requested review from a team and adonesky1 October 3, 2023 13:00
aloisklink
aloisklink approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@aloisklink aloisklink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

And it only took 1.75 years since #117 (comment) 😆

Thanks for also updating this package in MetaMask/eth-ledger-bridge-keyring#196!

@legobeat legobeat requested review from a team October 4, 2023 23:10
adonesky1
adonesky1 approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@adonesky1 adonesky1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@legobeat legobeat merged commit 4824f92 into MetaMask:main Oct 7, 2023
16 checks passed
@legobeat legobeat deleted the deps-hdkey-2 branch October 7, 2023 03:50
@legobeat legobeat mentioned this pull request Oct 31, 2023
Merged
14 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aloisklink aloisklink aloisklink approved these changes

@adonesky1 adonesky1 adonesky1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@legobeat @aloisklink @adonesky1