-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: replace webextension-polyfill-ts with webextension-polyfill + @types/webextension-polyfill #43
deps: replace webextension-polyfill-ts with webextension-polyfill + @types/webextension-polyfill #43
Conversation
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Next stepsTake a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with |
e202d0f
to
a1fa06d
Compare
At the point of this comment, the most recent release The intention here is that |
a1fa06d
to
6b563f6
Compare
New and updated dependency changes detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: webextension-polyfill-ts@0.26.0 Footnotes |
package.json
Outdated
"webextension-polyfill": ">=0.10.0" | ||
}, | ||
"devDependencies": { | ||
"@metamask/eslint-config": "^4.1.0", | ||
"@types/webextension-polyfill": ">=0.10.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Could we use a ^
range here instead? Seems more conventional and avoids post-v1 breaking changes in theory.
"webextension-polyfill": ">=0.10.0" | |
}, | |
"devDependencies": { | |
"@metamask/eslint-config": "^4.1.0", | |
"@types/webextension-polyfill": ">=0.10.0", | |
"webextension-polyfill": "^0.10.0" | |
}, | |
"devDependencies": { | |
"@metamask/eslint-config": "^4.1.0", | |
"@types/webextension-polyfill": "^0.10.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated both to >=0.10.0 <1.0
to keep it sub-1.0 (very reasonable) but open to bringing it down to ^0.10.0
only if still preferred.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems OK to me, though I'm not sure why this would be preferable to the more conventional ^0.10.0
range
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, though I did have one suggestion
6b563f6
to
4358fe5
Compare
…types/webextension-polyfill As can be seen in the lockfile diff, this implies a bump from webextension-polyfill to ^0.10.0. Keeping webextension-polyfill as a runtime dependency is intended as an intermediary measure, making it a peerDependency in a future update.
4358fe5
to
79debb2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense.
This is a follow-up on #37 .
As can be seen in the lockfile diff, this implies a bump of
webextension-polyfill
from0.8.0
to0.10.0
.Keeping webextension-polyfill as a runtime dependency is intended as an intermediary measure to keep this change non-breaking, making it a peerDependency in a future update.