Skip to content

INFRA-2867-Added chore prefix to PR, await for create release, remove commits.csv from changelog pr #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
XxdpavelxX merged 3 commits into from
Aug 27, 2025
Merged

INFRA-2867-Added chore prefix to PR, await for create release, remove commits.csv from changelog pr #111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0d0c372
INFRA-2867-Added chore prefix to PR, await for create release, remove…
XxdpavelxX Aug 27, 2025
4000ff0
INFRA-2867-Added release prefix to PR, await for create release, remo…
XxdpavelxX Aug 27, 2025
6447830
INFRA-2867-Added release prefix to PR, await for create release, remo…
XxdpavelxX Aug 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions .github/scripts/create-platform-release-pr.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,16 +349,14 @@ create_changelog_pr() {
# fi
cd ../

# Commit and Push Changelog Changes
# Commit and Push Changelog Changes (exclude commits.csv)
echo "Adding and committing changes.."
git add ./commits.csv
Copy link
Contributor

@gauthierpetetin gauthierpetetin Aug 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reached out to @jvbriones on Slack to confirm he's fine with this removal.


if ! (git commit -am "updated changelog and generated feature test plan"); then
if ! (git commit -am "update changelog for ${new_version}"); then
echo "Error: No changes detected."
exit 1
fi

local pr_body="This PR updates the change log for ${new_version} and generates the test plan here [commit.csv](${GITHUB_REPOSITORY_URL}/blob/${changelog_branch_name}/commits.csv)"
local pr_body="This PR updates the change log for ${new_version}."

# Use helper functions for push and PR creation
push_branch_with_handling "${changelog_branch_name}"
Expand Down Expand Up @@ -394,7 +392,7 @@ create_version_bump_pr() {
if git diff --staged --quiet; then
echo "No changes to commit for version bump"
else
git commit -m "Bump version to ${next_version} after release ${new_version}
git commit -m "release: Bump version to ${next_version} after release ${new_version}

This automated version bump ensures that:
- ${main_branch} branch version is ahead of the release branch
Expand Down Expand Up @@ -435,7 +433,7 @@ This PR should be **manually reviewed and merged by the release manager** to mai

# Use helper functions for push and PR creation
push_branch_with_handling "${version_bump_branch_name}"
create_pr_if_not_exists "${version_bump_branch_name}" "Bump ${main_branch} version to ${next_version}" "${version_bump_body}" "${main_branch}" "" "head"
create_pr_if_not_exists "${version_bump_branch_name}" "release: Bump ${main_branch} version to ${next_version}" "${version_bump_body}" "${main_branch}" "" "head"

echo "Version bump PR ready"
}
Expand Down
2 changes: 1 addition & 1 deletion .github/scripts/update-release-sheet.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,7 @@ async function main() {
extensionTemplateSheetId,
);

createReleaseSheet(
await createReleaseSheet(
Copy link
Contributor

@gauthierpetetin gauthierpetetin Aug 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is dead code that will be removed by @jvbriones (the entire file).

Copy link
Contributor Author

@XxdpavelxX XxdpavelxX Aug 27, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I will leave it here for now then until it's removed if there's no objections.

documentId,
platform,
semanticVersion,
Expand Down
9 changes: 9 additions & 0 deletions .github/workflows/create-release-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,3 +145,12 @@ jobs:
${{ inputs.mobile-build-version }} \
${{ inputs.git-user-name }} \
${{ inputs.git-user-email }}

# Step 6: Upload commits.csv as artifact (if generated)
- name: Upload commits.csv artifact
if: ${{ hashFiles('commits.csv') != '' }}
uses: actions/upload-artifact@v4
with:
name: commits-csv
path: commits.csv
if-no-files-found: error
Loading