Skip to content

ci: small fixes #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jvbriones merged 1 commit into from
Sep 4, 2025
Merged

ci: small fixes #117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/scripts/create-flaky-test-report.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -518,7 +518,7 @@ function createSlackBlocks(summary, dateDisplay, workflowCount = 0, failedCount
elements: [{
type: 'rich_text_section',
elements: [
{ type: 'text', text: ` ${errorPreview.replace(/\n/g, ' ')}` }
{ type: 'text', text: ` ${errorPreview.replace(/\n/g, ' ')}`, style: { italic: true } }
]
}]
});
Expand Down
13 changes: 7 additions & 6 deletions .github/scripts/post-merge-validation-tracker.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,11 @@ import { google } from 'googleapis';
import { Octokit } from '@octokit/rest';

const githubToken = process.env.GITHUB_TOKEN;
const spreadsheetId = process.env.SHEET_ID;
// can be found in the excel url e.g. https://docs.google.com/spreadsheets/d/1uSERA-Mczy0pjlrr1vv../
const spreadsheetId = process.env.SHEET_ID; // 1uSERA-Mczy0pjlrr1vv...
// GOOGLE_APPLICATION_CREDENTIALS_BASE64 can be found in MM QA 1pasword vault
const googleApplicationCredentialsBase64 = process.env.GOOGLE_APPLICATION_CREDENTIALS_BASE64;
const repo = process.env.REPO;
const repo = process.env.REPO || "MetaMask/metamask-extension";
const LOOKBACK_DAYS = parseInt(process.env.LOOKBACK_DAYS ?? '1');
const START_HOUR_UTC = parseInt(process.env.START_HOUR_UTC ?? '7');

Expand Down Expand Up @@ -57,18 +59,17 @@ function tabTitleFor(repo, releaseLabel) {

function headerRowFor(type) {
const isMobile = String(type).toLowerCase() === 'mobile';
const colF = isMobile ? 'Validated (Android)' : 'Validated (Chrome)';
const colG = isMobile ? 'Validated (iOS)' : 'Validated (Firefox)';
const colG = isMobile ? 'Validated (Android)' : 'Validated (Chrome)';
const colH = isMobile ? 'Validated (iOS)' : 'Validated (Firefox)';
return [
'Pull Request',
'Merged Time (UTC)',
'Author',
'PR Size',
'Auto Tests',
'Team Responsible',
colF,
colG,
'Comments',
colH,
Copy link

@cursor cursor bot Sep 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Column Mismatch Causes Spreadsheet Errors

The headerRowFor function now returns 8 columns after removing the 'Comments' column. However, data rows created in functions like buildTabGrouping and processTab still contain 9 elements, and spreadsheet ranges expect 9 columns. This mismatch causes column misalignment and incorrect data writing in the Google Sheet.

Fix in Cursor Fix in Web

];
}

Expand Down
Loading