fix: log merge group failure manual removal#33
Closed
itsyoboieltr wants to merge 1 commit intomainfrom
Closed
Conversation
7 tasks
Contributor
Author
|
We tested the fix, and it did not work, so we won't be handling the case of manual removals. It should happen rarely enough, that it will not significantly skew our numbers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During testing, we discovered that manually removed PRs were also reported as failed. This PR handles this case, as GitHub Actions continue running even after the PR has already been removed. The newly added step checks if the head commit hash is in the merge queue, and skips logging if it is not.
Fixes #12345