Conversation
|
Have you tried running this? I looked for run logs somewhere but didn't find any. I suspect that |
hi @HowardBraham 👋 Thank you for taking a look! So the work will be completed when I create the 2 platform PRs, one for Extension and Mobile, to add the flow there (like here). I haven't run it as I'm unsure how can I run this unless I create the PRs on the platforms 🤔 But it's a great point. I'll create the PRs and then see how can I test it and report back 🙏 |
|
Yeah you have to create the platform PRs and test them all together. There's no point in approving and merging this alone, it will never work correctly on the first try. |
mainmain
mainmain
There was a problem hiding this comment.
Bug: Bash Arithmetic Error with Null Values
The workflow fails with a bash arithmetic error when incrementing the success count. This occurs because the current_number_of_successes variable becomes the string "null" if an existing row for the current date in the Google Sheet has an empty or non-numeric value in column C. The jq expression responsible for parsing the sheet data returns "null" in such cases, which bash cannot use in the arithmetic operation $(("$current_number_of_successes" + 1)).
.github/workflows/log-merge-group-success.yml#L46-L47
github-tools/.github/workflows/log-merge-group-success.yml
Lines 46 to 47 in 4db842b
Was this report helpful? Give feedback by reacting with 👍 or 👎
|
closing in favour of #83 |
This PR creates a re-usable workflow which logs the number of PRs that get merged to main. The end goal of this is to extend our metrics, to better understand ci health, by getting the success merge rate, using both these data, and the number of PRs that get kicked out from the merge queue.
This PR is based on the work from @itsyoboieltr (see here)
Some notes: