Skip to content
This repository has been archived by the owner on Nov 9, 2023. It is now read-only.

Migrate to TypeScript #11

Merged
merged 5 commits into from
Dec 7, 2020
Merged

Migrate to TypeScript #11

merged 5 commits into from
Dec 7, 2020

Conversation

rekmarks
Copy link
Member

@rekmarks rekmarks commented Dec 3, 2020

  • Migrate to TypeScript
  • Update safe-event-emitter, dev dependencies

Copy link

@NiranjanaBinoy NiranjanaBinoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from a few lint issues, everything else looks good to me. I am not sure whether to select the comment option or Request change option here, since the suggestions are nothing major I am going with the comment option.

src/createEngineStream.ts Outdated Show resolved Hide resolved
src/createEngineStream.ts Outdated Show resolved Hide resolved
src/createStreamMiddleware.ts Outdated Show resolved Hide resolved
src/createStreamMiddleware.ts Outdated Show resolved Hide resolved
src/createStreamMiddleware.ts Outdated Show resolved Hide resolved
Copy link

@NiranjanaBinoy NiranjanaBinoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants