Skip to content
This repository has been archived by the owner on Nov 9, 2023. It is now read-only.

ci: test on nodejs versions 18 and 20 #63

Merged
merged 1 commit into from
Sep 21, 2023
Merged

ci: test on nodejs versions 18 and 20 #63

merged 1 commit into from
Sep 21, 2023

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Sep 12, 2023 •
edited
Loading

@legobeat legobeat mentioned this pull request Sep 12, 2023
Merged
@legobeat legobeat force-pushed the ci-node-18-20 branch 2 times, most recently from 84aeadf to 377acf6 Compare September 13, 2023 20:25
@legobeat legobeat marked this pull request as ready for review September 21, 2023 08:53
@legobeat legobeat requested a review from a team as a code owner September 21, 2023 08:53
mikesposito
mikesposito approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@mikesposito mikesposito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

cryptodev-2s
cryptodev-2s approved these changes Sep 21, 2023
View reviewed changes
Copy link

@cryptodev-2s cryptodev-2s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@legobeat legobeat merged commit 6f9cf5a into MetaMask:main Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cryptodev-2s cryptodev-2s cryptodev-2s approved these changes

@mikesposito mikesposito mikesposito approved these changes

@kanthesha kanthesha Awaiting requested review from kanthesha

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@legobeat @mikesposito @cryptodev-2s