Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to TypeScript #10

Merged
merged 3 commits into from
Feb 25, 2021
Merged

Migrate to TypeScript #10

merged 3 commits into from
Feb 25, 2021

Conversation

rekmarks
Copy link
Member

@rekmarks rekmarks commented Feb 25, 2021 •
edited
Loading

Migrates this package to TypeScript. Adds:

  • New package scripts
  • TypeScript dependencies
  • tsconfig.json
  • TypeScript source
    • Moves some functions around within files
    • No functional changes except some internal import / export behavior
  • eslint config
  • CI config

Closes #9

@rekmarks rekmarks requested a review from kumavis February 25, 2021 07:13
@rekmarks rekmarks requested a review from a team as a code owner February 25, 2021 07:13
astarinmymind
astarinmymind approved these changes Feb 25, 2021
View reviewed changes
Copy link

@astarinmymind astarinmymind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@rekmarks rekmarks merged commit 114c591 into main Feb 25, 2021
@rekmarks rekmarks deleted the typescript branch February 25, 2021 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astarinmymind astarinmymind astarinmymind approved these changes

@kumavis kumavis Awaiting requested review from kumavis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate to TypeScript
2 participants
@rekmarks @astarinmymind