Validate that master private key and seed are within bounds #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mrtenz
commented
Mar 1, 2023
| @@ -47,11 +48,21 @@ export async function deriveChildKey({ | |||
| */ | |||
| export async function createBip39KeyFromSeed( | |||
| seed: Uint8Array, | |||
| curve: Curve = secp256k1, | |||
There was a problem hiding this comment.
I've made this non-optional, because we were forgetting to pass ed25519 to this function in certain tests. It's better to be explicit here.
Mrtenz
force-pushed
the
mrtenz/validate-master-private-key
branch
from
2aab5f7 to
52ce799
Compare
Mrtenz
force-pushed
the
mrtenz/validate-master-private-key
branch
from
52ce799 to
764c7e9
Compare
FrederikBolding
approved these changes
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This validates that:
Related to MM-02-003 and MM-02-004.