Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deriveKeyFromPath interface, refactor derivers #14

Merged
merged 4 commits into from
Feb 27, 2021
Merged

Conversation

rekmarks
Copy link
Member

Ensures that deriveKeyFromPath parentKey parameter is optional. This required some refactoring of the internal derivers, since BIP-32 derivation requires a parentKey while BIP-39 does not. The public interface of this package remains unchanged.

@rekmarks rekmarks requested a review from a team as a code owner February 27, 2021 18:11
Copy link

@astarinmymind astarinmymind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice n Simple!

@rekmarks rekmarks merged commit 96343d0 into main Feb 27, 2021
@rekmarks rekmarks deleted the fix-types branch February 27, 2021 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants