Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronise package with module template (November 2023) #157

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

Mrtenz
Copy link
Member

@Mrtenz Mrtenz commented Nov 3, 2023

This has fixes for ESM support and small changes to CI.

@Mrtenz Mrtenz requested a review from a team as a code owner November 3, 2023 11:11
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
tsup 7.2.0 eval, network, filesystem, shell, environment +9 2.58 MB egoist

🚮 Removed packages: @swc/cli@0.1.62, @swc/core@1.3.95

Copy link

socket-security bot commented Nov 3, 2023

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: source-map@0.8.0-beta.0, esbuild@0.18.20

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

@Mrtenz
Copy link
Member Author

Mrtenz commented Nov 3, 2023

@SocketSecurity ignore source-map@0.8.0-beta.0
@SocketSecurity ignore esbuild@0.18.20

Copy link

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mcmire mcmire mentioned this pull request Jan 31, 2024
steps:
- uses: actions/checkout@v3
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}
cache: 'yarn'
- run: yarn --immutable --immutable-cache
- run: rm yarn.lock && YARN_ENABLE_IMMUTABLE_INSTALLS=false yarn
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't love this addition from the module template.

@Mrtenz Mrtenz merged commit 452ad52 into main Feb 7, 2024
14 checks passed
@Mrtenz Mrtenz deleted the mrtenz/module-template-november-2023 branch February 7, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants