Add network property #200
Merged
Add network property #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -458,6 +458,7 @@ export default { | |||
| masterFingerprint: 1247889873, | |||
| parentFingerprint: 0, | |||
| index: 0, | |||
| network: 'mainnet', | |||
There was a problem hiding this comment.
How come we need to add this here, but not for other fixtures?
There was a problem hiding this comment.
It's because of how the tests using these are written. They do a direct comparison of the JSON objects.
FrederikBolding
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BIP-32 specifies four different "versions" for extended keys. Public and private, but also mainnet and testnet. Previously we just assumed mainnet, because that's what's used for Ethereum, but to support other networks (such as Bitcoin), I've added a network field (i.e.,
mainnetortestnet), which determines which BIP-32 extended key version to use.