Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the multipath validation to allow for a broader range of sub-paths, and adds unit tests for the input validation. Paths starting with
bip32
segments will still require aparentKey
to be specified, and paths starting withbip39
will still require that noparentKey
is specified. Paths longer than 5bip32
segments will not be accepted, because BIP-44 only defines paths of length 5, excluding the seed.Specifically, we change the quantifier for intermediate
bip32
path segments of the multipath RegEx from{3,4}
to{0,4}
. In conjunction with the other RegEx validators, this means that the following multipaths will now be accepted:Prior to this PR, only the following multipaths were accepted: