-
-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade allow-scripts; add preinstall-always-fail #109
Conversation
This aligns this repo with our module template.
This commit aligns this repo with the module template: - Bump `@lavamoat/allow-scripts` to ^2.3.1 - Add `@lavamoat/preinstall-always-fail`, as it was being configured in the manifest, but not actually installed
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring: Next stepsTake a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with |
Socket errors are okay. We own the |
@SocketSecurity ignore npm/@lavamoat/preinstall-always-fail@2.1.0 This is OK, this is our package. |
@SocketSecurity ignore npm/write-file-atomic@5.0.1 These are OK, these are all direct or transitive dependencies of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This commit aligns this repo with the module template:
@lavamoat/allow-scripts
to ^2.3.1@lavamoat/preinstall-always-fail
, as it was being configured in the manifest, but not actually installed