Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade allow-scripts; add preinstall-always-fail #109

Merged
merged 7 commits into from
Feb 6, 2025
Merged

Conversation

mcmire
Copy link
Contributor

@mcmire mcmire commented Nov 29, 2023

This commit aligns this repo with the module template:

  • Bump @lavamoat/allow-scripts to ^2.3.1
  • Add @lavamoat/preinstall-always-fail, as it was being configured in the manifest, but not actually installed

This aligns this repo with our module template.
This commit aligns this repo with the module template:

- Bump `@lavamoat/allow-scripts` to ^2.3.1
- Add `@lavamoat/preinstall-always-fail`, as it was being configured in
  the manifest, but not actually installed
@mcmire mcmire requested a review from a team as a code owner November 29, 2023 19:26
Copy link

socket-security bot commented Nov 29, 2023

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@isaacs/cliui@8.0.2 None 0 27.8 kB isaacs
npm/@lavamoat/aa@4.3.1 None 0 0 B
npm/@lavamoat/allow-scripts@3.3.1 🔁 npm/@lavamoat/allow-scripts@1.0.6 None 0 0 B
npm/@lavamoat/preinstall-always-fail@2.1.0 🔁 npm/@lavamoat/preinstall-always-fail@1.0.0 None 0 3.53 kB lmbot
npm/@npmcli/agent@2.2.2 environment, network 0 17.7 kB npm-cli-ops
npm/@npmcli/fs@3.1.1 filesystem 0 26.5 kB lukekarrys
npm/@npmcli/git@5.0.8 environment, filesystem 0 23 kB npm-cli-ops
npm/@npmcli/node-gyp@3.0.0 🔁 npm/@npmcli/node-gyp@1.0.2 None 0 1.87 kB lukekarrys
npm/@npmcli/package-json@5.2.1 filesystem 0 39.5 kB npm-cli-ops
npm/@npmcli/promise-spawn@7.0.2 🔁 npm/@npmcli/promise-spawn@1.3.2 environment 0 12.2 kB npm-cli-ops
npm/@npmcli/run-script@8.1.0 🔁 npm/@npmcli/run-script@1.8.6 None 0 18.3 kB npm-cli-ops
npm/@pkgjs/parseargs@0.11.0 None 0 74.2 kB oss-bot
npm/abbrev@2.0.0 🔁 npm/abbrev@1.1.1 None 0 4.83 kB lukekarrys
npm/agent-base@7.1.3 network 0 31.5 kB tootallnate
npm/aggregate-error@3.1.0 None 0 6.69 kB sindresorhus
npm/bin-links@4.0.4 filesystem 0 20.7 kB npm-cli-ops
npm/brace-expansion@2.0.1 None 0 11.5 kB juliangruber
npm/cacache@18.0.4 filesystem 0 63.7 kB npm-cli-ops
npm/clean-stack@2.2.0 None 0 5.51 kB sindresorhus
npm/cliui@8.0.1 🔁 npm/cliui@7.0.4 None +2 42 kB oss-bot
npm/cmd-shim@6.0.3 filesystem 0 12.2 kB npm-cli-ops
npm/cross-spawn@7.0.6 🔁 npm/cross-spawn@7.0.3 None +2 37 kB satazor
npm/eastasianwidth@0.2.0 None 0 13.6 kB komagata
npm/encoding@0.1.13 None 0 7.12 kB andris
npm/err-code@2.0.3 None 0 12.3 kB achingbrain
npm/exponential-backoff@3.1.1 None 0 37.3 kB sssayegh
npm/foreground-child@3.3.0 shell 0 69 kB isaacs
npm/function-bind@1.1.2 🔁 npm/function-bind@1.1.1 None 0 31.4 kB ljharb
npm/graceful-fs@4.2.11 🔁 npm/graceful-fs@4.2.8 None 0 32.5 kB isaacs
npm/hasown@2.0.2 None 0 8.77 kB ljharb
npm/hosted-git-info@7.0.2 None 0 26.6 kB npm-cli-ops
npm/http-cache-semantics@4.1.1 None 0 35.9 kB kornel
npm/http-proxy-agent@7.0.2 network 0 23.3 kB tootallnate
npm/https-proxy-agent@7.0.6 network 0 35.2 kB tootallnate
npm/iconv-lite@0.6.3 None 0 349 kB ashtuchkin
npm/indent-string@4.0.0 None 0 4.4 kB sindresorhus
npm/ini@4.1.3 None 0 12.1 kB npm-cli-ops
npm/ip-address@9.0.5 None 0 177 kB beaugunderson
npm/is-core-module@2.16.1 🔁 npm/is-core-module@2.7.0 None 0 33.5 kB ljharb
npm/is-lambda@1.0.1 None 0 2.94 kB watson
npm/isexe@3.1.1 environment, filesystem 0 43 kB isaacs
npm/jackspeak@3.4.3 environment 0 297 kB isaacs
npm/jsbn@1.1.0 🔁 npm/jsbn@0.1.1 None 0 46.9 kB andyperlitch
npm/json-parse-even-better-errors@3.0.2 🔁 npm/json-parse-even-better-errors@2.3.1 None 0 9.94 kB npm-cli-ops
npm/lru-cache@10.4.3 None 0 804 kB isaacs
npm/make-fetch-happen@13.0.1 network 0 52.8 kB npm-cli-ops
npm/minimatch@9.0.5 environment 0 435 kB isaacs
npm/minipass-collect@2.0.1 None 0 4.96 kB isaacs
npm/minipass-fetch@3.0.5 environment, network 0 46.8 kB npm-cli-ops
npm/minipass-flush@1.0.5 None 0 3.77 kB isaacs
npm/minipass-pipeline@1.2.4 None 0 7 kB isaacs
npm/minipass-sized@1.0.3 None 0 124 kB isaacs
npm/ms@2.1.3 🔁 npm/ms@2.1.2 None 0 6.72 kB styfle
npm/negotiator@0.6.4 None 0 28.6 kB blakeembrey
npm/node-gyp@10.3.1 🔁 npm/node-gyp@7.1.2 None +4 2.45 MB nodejs-foundation
npm/nopt@7.2.1 🔁 npm/nopt@5.0.0 None 0 26.2 kB npm-cli-ops
npm/normalize-package-data@6.0.2 None 0 28.2 kB npm-cli-ops
npm/npm-install-checks@6.3.0 None 0 6.21 kB npm-cli-ops
npm/npm-package-arg@11.0.3 None 0 19.2 kB npm-cli-ops
npm/npm-pick-manifest@9.1.0 None 0 16.5 kB npm-cli-ops
npm/p-map@4.0.0 None 0 8.69 kB sindresorhus
npm/package-json-from-dist@1.0.1 None 0 36.5 kB isaacs
npm/path-scurry@1.11.1 filesystem 0 535 kB isaacs
npm/promise-inflight@1.0.1 None 0 3.04 kB iarna
npm/promise-retry@2.0.1 None 0 15.6 kB achingbrain
npm/read-cmd-shim@4.0.0 filesystem 0 5.16 kB lukekarrys
npm/readable-stream@2.3.6 🔁 npm/readable-stream@2.3.7 None +1 91.8 kB matteo.collina
npm/resolve@1.22.8 🔁 npm/resolve@1.20.0 environment 0 145 kB ljharb
npm/retry@0.12.0 None 0 32.2 kB tim-kos
npm/semver@7.7.1 None 0 96.7 kB fritzy, gar, hashtagchris, ...3 more
npm/signal-exit@4.1.0 None 0 77 kB isaacs
npm/smart-buffer@4.2.0 None 0 138 kB joshglazebrook
npm/socks-proxy-agent@8.0.5 network 0 25.5 kB tootallnate
npm/socks@2.8.3 network 0 156 kB joshglazebrook
npm/sprintf-js@1.1.3 None 0 39.9 kB alexei
npm/ssri@10.0.6 None 0 38.7 kB npm-cli-ops
npm/string-width-cjs@4.2.3 None 0 0 B
npm/strip-ansi-cjs@6.0.1 None 0 0 B
npm/supports-preserve-symlinks-flag@1.0.0 None 0 9.18 kB ljharb
npm/type-fest@4.30.0 None 0 400 kB sindresorhus
npm/unique-filename@3.0.0 None 0 3.41 kB lukekarrys
npm/unique-slug@4.0.0 None 0 2.58 kB lukekarrys
npm/validate-npm-package-name@5.0.1 unsafe 0 7.77 kB npm-cli-ops
npm/which@4.0.0 environment 0 7.5 kB npm-cli-ops
npm/wrap-ansi-cjs@7.0.0 None 0 0 B
npm/write-file-atomic@5.0.1 filesystem 0 12.2 kB npm-cli-ops
npm/yargs-parser@21.1.1 🔁 npm/yargs-parser@20.2.7 None 0 128 kB oss-bot
npm/yargs@17.7.2 🔁 npm/yargs@16.2.0, npm/yargs@17.0.1 None 0 292 kB oss-bot

🚮 Removed packages: npm/@yarnpkg/lockfile@1.1.0, npm/aproba@1.2.0, npm/are-we-there-yet@1.1.7, npm/asn1@0.2.4, npm/assert-plus@1.0.0, npm/asynckit@0.4.0, npm/aws-sign2@0.7.0, npm/aws4@1.11.0, npm/bcrypt-pbkdf@1.0.2, npm/caseless@0.12.0, npm/code-point-at@1.1.0, npm/combined-stream@1.0.8, npm/console-control-strings@1.1.0, npm/dashdash@1.14.1, npm/delayed-stream@1.0.0, npm/delegates@1.0.0, npm/ecc-jsbn@0.1.2, npm/extend@3.0.2, npm/extsprintf@1.3.0, npm/forever-agent@0.6.1, npm/form-data@2.3.3, npm/gauge@2.7.4, npm/getpass@0.1.7, npm/har-schema@2.0.0, npm/har-validator@5.1.5, npm/has-unicode@2.0.1, npm/http-signature@1.2.0, npm/infer-owner@1.0.4, npm/is-typedarray@1.0.0, npm/isstream@0.1.2, npm/json-schema@0.2.3, npm/json-stringify-safe@5.0.1, npm/jsprim@1.4.1, npm/mime-db@1.50.0, npm/npm-logical-tree@1.2.1, npm/npmlog@4.1.2, npm/number-is-nan@1.0.1, npm/oauth-sign@0.9.0, npm/object-assign@4.1.1, npm/performance-now@2.1.0, npm/psl@1.8.0, npm/qs@6.5.3, npm/read-package-json-fast@2.0.3, npm/request@2.88.2, npm/set-blocking@2.0.0, npm/sshpk@1.16.1, npm/tough-cookie@2.5.0, npm/tunnel-agent@0.6.0, npm/uuid@3.4.0, npm/verror@1.10.0, npm/wide-align@1.1.3

View full report↗︎

Copy link

socket-security bot commented Nov 29, 2023

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/write-file-atomic@5.0.1, npm/exponential-backoff@3.1.1, npm/read-cmd-shim@4.0.0, npm/http-proxy-agent@7.0.2, npm/@npmcli/agent@2.2.2, npm/socks@2.8.3, npm/make-fetch-happen@13.0.1, npm/minipass-fetch@3.0.5, npm/validate-npm-package-name@5.0.1, npm/foreground-child@3.3.0, npm/negotiator@0.6.4, npm/https-proxy-agent@7.0.6, npm/socks-proxy-agent@8.0.5, npm/agent-base@7.1.3, npm/npm-normalize-package-bin@3.0.1, npm/abbrev@2.0.0, npm/@npmcli/node-gyp@3.0.0, npm/@lavamoat/preinstall-always-fail@2.1.0

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

Base automatically changed from bump-to-node-18 to main November 29, 2023 19:52
@mcmire
Copy link
Contributor Author

mcmire commented Nov 29, 2023

Socket errors are okay. We own the @lavamoat/* packages, and ljharb, lukekarrys, and gar are trusted authors.

package.json Outdated Show resolved Hide resolved
@mcmire
Copy link
Contributor Author

mcmire commented Feb 6, 2025

@SocketSecurity ignore npm/@lavamoat/preinstall-always-fail@2.1.0

This is OK, this is our package.

@mcmire
Copy link
Contributor Author

mcmire commented Feb 6, 2025

@SocketSecurity ignore npm/write-file-atomic@5.0.1
@SocketSecurity ignore npm/exponential-backoff@3.1.1
@SocketSecurity ignore npm/read-cmd-shim@4.0.0
@SocketSecurity ignore npm/http-proxy-agent@7.0.2
@SocketSecurity ignore npm/@npmcli/agent@2.2.2
@SocketSecurity ignore npm/socks@2.8.3
@SocketSecurity ignore npm/make-fetch-happen@13.0.1
@SocketSecurity ignore npm/minipass-fetch@3.0.5
@SocketSecurity ignore npm/validate-npm-package-name@5.0.1
@SocketSecurity ignore npm/foreground-child@3.3.0
@SocketSecurity ignore npm/negotiator@0.6.4
@SocketSecurity ignore npm/https-proxy-agent@7.0.6
@SocketSecurity ignore npm/socks-proxy-agent@8.0.5
@SocketSecurity ignore npm/agent-base@7.1.3
@SocketSecurity ignore npm/npm-normalize-package-bin@3.0.1
@SocketSecurity ignore npm/abbrev@2.0.0
@SocketSecurity ignore npm/@npmcli/node-gyp@3.0.0

These are OK, these are all direct or transitive dependencies of allow-scripts. And the new authors are OK too, they are all known actors.

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mcmire mcmire merged commit 532580d into main Feb 6, 2025
11 checks passed
@mcmire mcmire deleted the align-lavamoat branch February 6, 2025 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants