Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add eslint #35

Merged
merged 4 commits into from
Aug 20, 2020
Merged

Add eslint #35

merged 4 commits into from
Aug 20, 2020

Conversation

rekmarks
Copy link
Member

@rekmarks rekmarks commented Aug 19, 2020 •
edited
Loading

  • Add eslint, @metamask/eslint-config, and relevant plugins
  • Lint
    • Package updates and lint:fix were applied in 50fc181
    • Manual rule fixes were applied in c8d62c3 for ease of review
  • Notes on rules
    • no-mixed-operators is disabled for now to lessen the review burden; it can be enabled later.
    • We should probably just continue to disable prefer-destructuring for arrays and no-bitwise.

@rekmarks rekmarks requested a review from a team as a code owner August 19, 2020 23:23
Gudahtt
Gudahtt reviewed Aug 20, 2020
View reviewed changes
bundle.js Show resolved Hide resolved
convert.js Outdated Show resolved Hide resolved
Gudahtt
Gudahtt approved these changes Aug 20, 2020
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rekmarks rekmarks merged commit e7cb9c9 into master Aug 20, 2020
@rekmarks rekmarks deleted the lint branch August 20, 2020 04:50
@whymarrh whymarrh mentioned this pull request Aug 20, 2020
Merged
@whymarrh
Copy link
Contributor

  • We should probably just continue to disable prefer-destructuring for arrays [...]

I've created MetaMask/eslint-config#57 to update the base config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rekmarks @whymarrh @Gudahtt