Skip to content

Commit

Permalink
chore: upgrading storybook to 8.5.3 (#412)
Browse files Browse the repository at this point in the history
## **Description**

This PR updates Storybook and related dependencies from v8.3.5 to
v8.5.3. Key improvements include:

- ♿️ Realtime accessibility tests with enhanced a11y addon (axe-core
integration)
- 🛡️ Project code coverage tracking for test completeness
- 🎯 Focused tests feature for faster feedback
- ⚛️ React Native Web Vite framework support
- ✅ Support for React 19, Vite 6, and Angular 19
- 🔧 Experimental Bun and Nuxt support

https://storybook.js.org/blog/storybook-8-5/

## **Related issues**

Fixes: N/A

## **Manual testing steps**

1. Pull down this branch
2. Run `yarn install` to update dependencies
3. Start Storybook with `yarn storybook`
4. Verify that:
   - Storybook loads successfully
   - Components render correctly
   - New a11y tests run properly
 
## **Screenshots/Recordings**

### **After**


https://github.com/user-attachments/assets/5a554c6c-9100-44bf-8287-a8e28ff9a480

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs)
- [x] I've completed the PR template to the best of my ability
- [x] I've verified Storybook works correctly with the updated version
- [x] I've tested the new a11y features and coverage reporting
- [x] I've applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (pulled branch, ran Storybook,
verified functionality)
- [ ] I confirm that Storybook and all components render and function
correctly with the updated version
- [ ] I've verified the new a11y testing features work as expected
  • Loading branch information
georgewrmarshall authored Feb 4, 2025
1 parent 4812f88 commit a1d04ad
Show file tree
Hide file tree
Showing 4 changed files with 226 additions and 199 deletions.
20 changes: 10 additions & 10 deletions apps/storybook-react/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,15 +12,15 @@
"@chromatic-com/storybook": "^1.9.0",
"@metamask/design-system-tailwind-preset": "workspace:^",
"@metamask/design-tokens": "workspace:^",
"@storybook/addon-a11y": "^8.3.5",
"@storybook/addon-essentials": "^8.3.5",
"@storybook/addon-interactions": "^8.3.5",
"@storybook/addon-links": "^8.3.5",
"@storybook/addon-onboarding": "^8.3.5",
"@storybook/blocks": "^8.3.5",
"@storybook/react": "^8.3.5",
"@storybook/react-vite": "^8.3.5",
"@storybook/test": "^8.3.5",
"@storybook/addon-a11y": "^8.5.3",
"@storybook/addon-essentials": "^8.5.3",
"@storybook/addon-interactions": "^8.5.3",
"@storybook/addon-links": "^8.5.3",
"@storybook/addon-onboarding": "^8.5.3",
"@storybook/blocks": "^8.5.3",
"@storybook/react": "^8.5.3",
"@storybook/react-vite": "^8.5.3",
"@storybook/test": "^8.5.3",
"@types/prop-types": "^15",
"@types/react": "^18.2.0",
"@types/react-dom": "^18.2.0",
Expand All @@ -29,7 +29,7 @@
"prop-types": "^15.8.1",
"react": "^18.2.0",
"react-dom": "^18.2.0",
"storybook": "^8.3.5",
"storybook": "^8.5.3",
"tailwindcss": "^3.0.0",
"typescript": "~5.2.2",
"vite": "^5.4.12"
Expand Down
4 changes: 2 additions & 2 deletions packages/design-system-react/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,8 @@
"@jest/globals": "^29.7.0",
"@metamask/auto-changelog": "^4.1.0",
"@metamask/design-system-tailwind-preset": "workspace:^",
"@storybook/react": "^8.3.5",
"@storybook/test": "^8.3.5",
"@storybook/react": "^8.5.3",
"@storybook/test": "^8.5.3",
"@svgr/cli": "^8.1.0",
"@testing-library/jest-dom": "^6.6.3",
"@testing-library/react": "^16.0.1",
Expand Down
2 changes: 1 addition & 1 deletion packages/design-tokens/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
"devDependencies": {
"@metamask/auto-changelog": "^4.1.0",
"@metamask/design-system-react": "workspace:^",
"@storybook/react": "^8.3.5",
"@storybook/react": "^8.5.3",
"@ts-bridge/cli": "^0.5.1",
"@types/jest": "^27.4.1",
"@types/node": "^16.18.54",
Expand Down
Loading

0 comments on commit a1d04ad

Please sign in to comment.