Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(docs): ACT-1360 - Components For Complex Types #1370

Merged
merged 30 commits into from
Jul 3, 2024
Merged

feat(docs): ACT-1360 - Components For Complex Types #1370

merged 30 commits into from
Jul 3, 2024

Conversation

aednikanov
Copy link
Contributor

Description

Components For Complex Types

TrofimovAnton85 and others added 18 commits June 4, 2024 13:17
@TrofimovAnton85
feat(docs): added rpc-parser component for reference pages
1622ec2
@TrofimovAnton85
feat(docs): added mm install msg
91e4c73
@TrofimovAnton85
feat(docs): change mm condition
6fcb4e3
@TrofimovAnton85
feat(docs): refactored styles
f5f83fd
@TrofimovAnton85
feat(docs): added request/response section
65909aa
@TrofimovAnton85
feat(docs): added error section
8ef761b
@TrofimovAnton85
feat(docs): added eth_call
dccba1c
@aednikanov
added default logic for InteractiveBox
b9f308f
@aednikanov
Merge branch 'main' into ACT-1359-add-params-table
b26ed1b
@aednikanov
Made enhancements for components
3280670
@aednikanov
returned condition for disabled button
4d56f44
@aednikanov
removed not needed styles in Drawer
d708ed3
@aednikanov
started implementing of handling complex types
b4b3bdb
@aednikanov
Merge branch 'main' into ACT-1360-components-for-complex-types
e58c3be
@aednikanov
made some progress
53b88b8
@aednikanov
Merge branch 'main' into ACT-1360-components-for-complex-types
36e2edd
@aednikanov
added UI and logic for complex array
cb51841
@aednikanov
Merge branch 'main' into ACT-1360-components-for-complex-types
10fe4de
@vercel Vercel
Copy link

vercel bot commented Jun 27, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
metamask-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 3, 2024 7:38pm

@aednikanov aednikanov marked this pull request as ready for review July 2, 2024 13:46
@aednikanov aednikanov requested a review from a team as a code owner July 2, 2024 13:46
joaniefromtheblock
joaniefromtheblock previously approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@joaniefromtheblock joaniefromtheblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexandratran
Copy link
Contributor

alexandratran commented Jul 3, 2024 •
edited
Loading

I'm unable to edit the to and block parameters, as shown in the following screen recording. The value box is uneditable, and when I select an option from the oneOf/anyOf dropdown, it goes to the same screen, but I still can't edit the value box and I also can't scroll down. I'm on Brave browser.

screen.recording.mov

alexandratran
alexandratran approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@alexandratran alexandratran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aednikanov aednikanov merged commit c4c3e73 into main Jul 3, 2024
6 checks passed
@aednikanov aednikanov deleted the ACT-1360-components-for-complex-types branch July 3, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandratran alexandratran alexandratran approved these changes

@joaniefromtheblock joaniefromtheblock Awaiting requested review from joaniefromtheblock

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aednikanov @alexandratran @joaniefromtheblock @TrofimovAnton85