Fix logic for triggering nft tabs spans endTrace calls

MetaMask · Nov 5, 2024 · 05131aa · 05131aa
1 parent 0d5b194
commit 05131aa
Showing 1 changed file with 3 additions and 6 deletions.
diff --git a/ui/components/app/assets/nfts/nfts-tab/nfts-tab.js b/ui/components/app/assets/nfts/nfts-tab/nfts-tab.js
@@ -96,15 +96,12 @@ export default function NftsTab() {
 
   useEffect(() => {
     if (showNftBanner) {
-      if (nftsLoading) {
-        endTrace({ name: TraceName.AccountOverviewNftsTabFMP });
-      } else {
-        endTrace({ name: TraceName.AccountOverviewNftsTab });
-      }
+      endTrace({ name: TraceName.AccountOverviewNftsTabFMP });
+      endTrace({ name: TraceName.AccountOverviewNftsTab });
     } else {
       // Preferring nested if-else over 'else if' for readability
       // eslint-disable-next-line no-lonely-if
-      if (nftsStillFetchingIndication) {
+      if (nftsLoading || nftsStillFetchingIndication) {
         endTrace({ name: TraceName.AccountOverviewNftsTabFMP });
       } else {
         endTrace({ name: TraceName.AccountOverviewNftsTab });