wip

MetaMask · Nov 20, 2024 · 0d56e3b · 0d56e3b
1 parent 6923756
commit 0d56e3b
Show file tree

Hide file tree

Showing 8 changed files with 39 additions and 13 deletions.
diff --git a/...nents/confirm/info/shared/edit-gas-fees-row/__snapshots__/edit-gas-fees-row.test.tsx.snap b/...nents/confirm/info/shared/edit-gas-fees-row/__snapshots__/edit-gas-fees-row.test.tsx.snap
@@ -45,12 +45,23 @@ exports[`<EditGasFeesRow /> renders component 1`] = `
       >
         0.001 ETH
       </p>
-      <p
-        class="mm-box mm-text mm-text--body-md mm-box--margin-right-2 mm-box--color-text-alternative"
-        data-testid="native-currency"
-      >
-        $1
-      </p>
+      <div>
+        <div
+          aria-describedby="tippy-tooltip-2"
+          class=""
+          data-original-title="0.001234"
+          data-tooltipped=""
+          style="display: inline;"
+          tabindex="0"
+        >
+          <p
+            class="mm-box mm-text mm-text--body-md mm-box--margin-right-2 mm-box--color-text-alternative"
+            data-testid="native-currency"
+          >
+            $1
+          </p>
+        </div>
+      </div>
       <button
         class="mm-box mm-text mm-button-base mm-button-base--size-sm mm-button-link mm-text--body-md-medium mm-box--padding-0 mm-box--padding-right-0 mm-box--padding-left-0 mm-box--display-inline-flex mm-box--justify-content-center mm-box--align-items-center mm-box--color-primary-default mm-box--background-color-transparent"
         data-testid="edit-gas-fee-icon"

diff --git a/...firmations/components/confirm/info/shared/edit-gas-fees-row/edit-gas-fees-row.stories.tsx b/...firmations/components/confirm/info/shared/edit-gas-fees-row/edit-gas-fees-row.stories.tsx
@@ -35,6 +35,7 @@ export const DefaultStory = () => (
   <EditGasFeesRow
     fiatFee="$1"
     nativeFee="0.001 ETH"
+    fiatFeeWith18SignificantDigits="0.001234"
     supportsEIP1559={true}
     setShowCustomizeGasPopover={() => {}}
   />

diff --git a/...confirmations/components/confirm/info/shared/edit-gas-fees-row/edit-gas-fees-row.test.tsx b/...confirmations/components/confirm/info/shared/edit-gas-fees-row/edit-gas-fees-row.test.tsx
@@ -25,6 +25,7 @@ describe('<EditGasFeesRow />', () => {
       <EditGasFeesRow
         fiatFee="$1"
         nativeFee="0.001 ETH"
+        fiatFeeWith18SignificantDigits="0.001234"
         supportsEIP1559={true}
         setShowCustomizeGasPopover={() => console.log('open popover')}
       />,

diff --git a/...ages/confirmations/components/confirm/info/shared/edit-gas-fees-row/edit-gas-fees-row.tsx b/...ages/confirmations/components/confirm/info/shared/edit-gas-fees-row/edit-gas-fees-row.tsx
@@ -27,7 +27,7 @@ export const EditGasFeesRow = ({
   setShowCustomizeGasPopover,
 }: {
   fiatFee: string;
-  fiatFeeWith18SignificantDigits: string;
+  fiatFeeWith18SignificantDigits: string | null;
   nativeFee: string;
   supportsEIP1559: boolean;
   setShowCustomizeGasPopover: Dispatch<SetStateAction<boolean>>;

diff --git a/...ions/components/confirm/info/shared/gas-fees-row/__snapshots__/gas-fees-row.test.tsx.snap b/...ions/components/confirm/info/shared/gas-fees-row/__snapshots__/gas-fees-row.test.tsx.snap
@@ -42,11 +42,22 @@ exports[`<GasFeesRow /> renders component 1`] = `
       >
         0.0001 ETH
       </p>
-      <p
-        class="mm-box mm-text mm-text--body-md mm-box--color-text-alternative"
-      >
-        $1
-      </p>
+      <div>
+        <div
+          aria-describedby="tippy-tooltip-2"
+          class=""
+          data-original-title="0.001234"
+          data-tooltipped=""
+          style="display: inline;"
+          tabindex="0"
+        >
+          <p
+            class="mm-box mm-text mm-text--body-md mm-box--color-text-alternative"
+          >
+            $1
+          </p>
+        </div>
+      </div>
     </div>
   </div>
 </div>

diff --git a/ui/pages/confirmations/components/confirm/info/shared/gas-fees-row/gas-fees-row.stories.tsx b/ui/pages/confirmations/components/confirm/info/shared/gas-fees-row/gas-fees-row.stories.tsx
@@ -38,6 +38,7 @@ export const DefaultStory = () => (
       label="Some kind of fee"
       tooltipText="Tooltip text"
       fiatFee="$1"
+      fiatFeeWith18SignificantDigits="0.001234"
       nativeFee="0.0001 ETH"
     />
   </ConfirmContextProvider>

diff --git a/ui/pages/confirmations/components/confirm/info/shared/gas-fees-row/gas-fees-row.test.tsx b/ui/pages/confirmations/components/confirm/info/shared/gas-fees-row/gas-fees-row.test.tsx
@@ -17,6 +17,7 @@ describe('<GasFeesRow />', () => {
         label="Some kind of fee"
         tooltipText="Tooltip text"
         fiatFee="$1"
+        fiatFeeWith18SignificantDigits="0.001234"
         nativeFee="0.0001 ETH"
       />,
       mockStore,

diff --git a/ui/pages/confirmations/components/confirm/info/shared/gas-fees-row/gas-fees-row.tsx b/ui/pages/confirmations/components/confirm/info/shared/gas-fees-row/gas-fees-row.tsx
@@ -30,7 +30,7 @@ export const GasFeesRow = ({
   label: string;
   tooltipText: string;
   fiatFee: string;
-  fiatFeeWith18SignificantDigits: string;
+  fiatFeeWith18SignificantDigits: string | null;
   nativeFee: string;
   'data-testid'?: string;
 }) => {