Addressed review comments

MetaMask · Oct 23, 2024 · 88d5179 · 88d5179
1 parent 2caa271
commit 88d5179
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 10 deletions.
diff --git a/...page-objects/pages/dialog/notification.ts → ...alog/network-switch-modal-confirmation.ts b/...page-objects/pages/dialog/notification.ts → ...alog/network-switch-modal-confirmation.ts
@@ -1,6 +1,6 @@
 import { Driver } from '../../../webdriver/driver';
 
-class Notification {
+class networkSwitchModalConfirmation {
   private driver: Driver;
 
   private submitButton: string;
@@ -12,8 +12,8 @@ class Notification {
 
   async clickApproveButton(): Promise<void> {
     console.log('Click Approve Button');
-    await this.driver.clickElement(this.submitButton);
+    await this.driver.clickElementAndWaitToDisappear(this.submitButton);
   }
 }
 
-export default Notification;
+export default networkSwitchModalConfirmation;
diff --git a/test/e2e/page-objects/pages/dialog/select-network.ts b/test/e2e/page-objects/pages/dialog/select-network.ts
@@ -37,7 +37,7 @@ class SelectNetwork {
 
   async clickCloseButton(): Promise<void> {
     console.log('Click Close Button');
-    await this.driver.clickElement(this.closeButton);
+    await this.driver.clickElementAndWaitToDisappear(this.closeButton);
   }
 
   async clickToggleButton(): Promise<void> {
@@ -52,7 +52,7 @@ class SelectNetwork {
 
   async clickAddButton(): Promise<void> {
     console.log('Click Add Button');
-    await this.driver.clickElement('[data-testid="test-add-button"]');
+    await this.driver.clickElementAndWaitToDisappear('[data-testid="test-add-button"]');
   }
 }
 

diff --git a/test/e2e/tests/network/switch-network.spec.ts b/test/e2e/tests/network/switch-network.spec.ts
@@ -5,12 +5,12 @@ import FixtureBuilder from '../../fixture-builder';
 import { Ganache } from '../../seeder/ganache';
 import { loginWithBalanceValidation } from '../../page-objects/flows/login.flow';
 import HomePage from '../../page-objects/pages/homepage';
-import Notification from '../../page-objects/pages/dialog/notification';
+import ModalConfirmation from '../../page-objects/pages/dialog/network-switch-modal-confirmation';
 import HeaderNavbar from '../../page-objects/pages/header-navbar';
 import SelectNetwork from '../../page-objects/pages/dialog/select-network';
 
 describe('Switch network - ', function (this: Suite) {
-  it('Ethereum Mainnet and Sepolia', async function () {
+  it('multiple networks', async function () {
     await withFixtures(
       {
         fixtures: new FixtureBuilder().build(),
@@ -28,7 +28,7 @@ describe('Switch network - ', function (this: Suite) {
         const homePage = new HomePage(driver);
         const headerNavbar = new HeaderNavbar(driver);
         const selectNetwork = new SelectNetwork(driver);
-        const notification = new Notification(driver);
+        const networkSwitchConfirmation = new ModalConfirmation(driver);
 
         // Validate the default network is Localhost 8545
         await headerNavbar.check_currentSelectedNetwork('Localhost 8545');
@@ -45,11 +45,11 @@ describe('Switch network - ', function (this: Suite) {
         await homePage.check_expectedBalanceIsDisplayed('25');
         await headerNavbar.check_currentSelectedNetwork('Localhost 8545');
 
-        // Add Aribtrum network and perform the switch network functionality
+        // Add Arbitrum network and perform the switch network functionality
         await headerNavbar.clickSwitchNetworkDropDown();
         await selectNetwork.fillNetworkSearchInput('Arbitrum One');
         await selectNetwork.clickAddButton();
-        await notification.clickApproveButton();
+        await networkSwitchConfirmation.clickApproveButton();
         await headerNavbar.clickSwitchNetworkDropDown();
         await selectNetwork.clickNetworkName('Arbitrum One');
         await homePage.check_expectedBalanceIsDisplayed('25');